linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com>
Cc: Amerigo Wang <amwang@redhat.com>,
	Kexec-ml <kexec@lists.infradead.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Milton Miller <miltonm@bga.com>,
	linuxppc-dev <linuxppc-dev@ozlabs.org>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Anton Blanchard <anton@samba.org>,
	Vivek Goyal <vgoyal@redhat.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [RFC PATCH v6 00/10] fadump: Firmware-assisted dump support for Powerpc.
Date: Wed, 15 Feb 2012 15:16:09 +1100	[thread overview]
Message-ID: <20120215041608.GA15258@bloggs.ozlabs.ibm.com> (raw)
In-Reply-To: <20111210064301.10195.3344.stgit@mars.in.ibm.com>

On Sat, Dec 10, 2011 at 12:19:59PM +0530, Mahesh J Salgaonkar wrote:

> The most of the code implementation has been adapted from phyp assisted dump
> implementation written by Linas Vepstas and Manish Ahuja.

When you repost the series, please be explicit about what the
relationship between the new fadump facility and the old phyp-dump
is, both in the documentation you're adding and in the patch
descriptions.

I gather that fadump uses the same firmware interfaces as phyp-dump,
and can be characterised as a rewrite of phyp-dump.  It would be good
if you would explicitly mention:

- What advantages fadump has over phyp-dump
- Whether there are any capabilities that phyp-dump does that fadump
  doesn't
- What is different between fadump and phyp-dump in the interface to
  usermode code
- Any user-visible differences between how fadump operates compared to
  phyp-dump.  For example, will users see a difference in how much
  memory is available to the kernel?

Paul.

      parent reply	other threads:[~2012-02-15  4:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-10  6:49 [RFC PATCH v6 00/10] fadump: Firmware-assisted dump support for Powerpc Mahesh J Salgaonkar
2011-12-10  6:50 ` [RFC PATCH v6 01/10] fadump: Add documentation for firmware-assisted dump Mahesh J Salgaonkar
2011-12-10  6:50 ` [RFC PATCH v6 02/10] fadump: Reserve the memory for firmware assisted dump Mahesh J Salgaonkar
2011-12-10  6:50 ` [RFC PATCH v6 03/10] fadump: Register " Mahesh J Salgaonkar
2011-12-10  6:50 ` [RFC PATCH v6 04/10] fadump: Initialize elfcore header and add PT_LOAD program headers Mahesh J Salgaonkar
2011-12-10  6:50 ` [RFC PATCH v6 05/10] fadump: Convert firmware-assisted cpu state dump data into elf notes Mahesh J Salgaonkar
2011-12-10  6:50 ` [RFC PATCH v6 06/10] fadump: Add PT_NOTE program header for vmcoreinfo Mahesh J Salgaonkar
2011-12-10  6:51 ` [RFC PATCH v6 07/10] fadump: Introduce cleanup routine to invalidate /proc/vmcore Mahesh J Salgaonkar
2011-12-10  6:51 ` [RFC PATCH v6 08/10] fadump: Invalidate registration and release reserved memory for general use Mahesh J Salgaonkar
2011-12-10  6:51 ` [RFC PATCH v6 09/10] fadump: Invalidate the fadump registration during machine shutdown Mahesh J Salgaonkar
2011-12-10  6:51 ` [RFC PATCH v6 10/10] fadump: Remove the phyp assisted dump code Mahesh J Salgaonkar
2012-02-15  4:16 ` Paul Mackerras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120215041608.GA15258@bloggs.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=amwang@redhat.com \
    --cc=anton@samba.org \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mahesh@linux.vnet.ibm.com \
    --cc=miltonm@bga.com \
    --cc=rdunlap@xenotime.net \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).