From: Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com>
To: linuxppc-dev <linuxppc-dev@ozlabs.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Anton Blanchard <anton@samba.org>,
Amerigo Wang <amwang@redhat.com>,
Kexec-ml <kexec@lists.infradead.org>,
Milton Miller <miltonm@bga.com>,
Randy Dunlap <rdunlap@xenotime.net>,
Paul Mackerras <paulus@samba.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Vivek Goyal <vgoyal@redhat.com>
Subject: [RFC PATCH v7 07/10] fadump: Introduce cleanup routine to invalidate /proc/vmcore.
Date: Thu, 16 Feb 2012 16:45:00 +0530 [thread overview]
Message-ID: <20120216111459.4733.83147.stgit@mars> (raw)
In-Reply-To: <20120216111050.4733.38034.stgit@mars>
From: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
With the firmware-assisted dump support we don't require a reboot when we
are in second kernel after crash. The second kernel after crash is a normal
kernel boot and has knowledge about entire system RAM with the page tables
initialized for entire system RAM. Hence once the dump is saved to disk, we
can just release the reserved memory area for general use and continue
with second kernel as production kernel.
Hence when we release the reserved memory that contains dump data, the
'/proc/vmcore' will not be valid anymore. Hence this patch introduces
a cleanup routine that invalidates and removes the /proc/vmcore file. This
routine will be invoked before we release the reserved dump memory area.
Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
---
fs/proc/vmcore.c | 23 +++++++++++++++++++++++
1 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c
index b0f450a..0d5071d 100644
--- a/fs/proc/vmcore.c
+++ b/fs/proc/vmcore.c
@@ -700,3 +700,26 @@ static int __init vmcore_init(void)
return 0;
}
module_init(vmcore_init)
+
+/* Cleanup function for vmcore module. */
+void vmcore_cleanup(void)
+{
+ struct list_head *pos, *next;
+
+ if (proc_vmcore) {
+ remove_proc_entry(proc_vmcore->name, proc_vmcore->parent);
+ proc_vmcore = NULL;
+ }
+
+ /* clear the vmcore list. */
+ list_for_each_safe(pos, next, &vmcore_list) {
+ struct vmcore *m;
+
+ m = list_entry(pos, struct vmcore, list);
+ list_del(&m->list);
+ kfree(m);
+ }
+ kfree(elfcorebuf);
+ elfcorebuf = NULL;
+}
+EXPORT_SYMBOL_GPL(vmcore_cleanup);
next prev parent reply other threads:[~2012-02-16 11:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 11:14 [RFC PATCH v7 00/10] fadump: Firmware-assisted dump support for Powerpc Mahesh J Salgaonkar
2012-02-16 11:14 ` [RFC PATCH v7 01/10] fadump: Add documentation for firmware-assisted dump Mahesh J Salgaonkar
2012-02-16 11:14 ` [RFC PATCH v7 02/10] fadump: Reserve the memory for firmware assisted dump Mahesh J Salgaonkar
2012-02-16 11:14 ` [RFC PATCH v7 03/10] fadump: Register " Mahesh J Salgaonkar
2012-02-20 0:02 ` Paul Mackerras
2012-02-20 12:15 ` [UPDATED] " Mahesh J Salgaonkar
2012-02-16 11:14 ` [RFC PATCH v7 04/10] fadump: Initialize elfcore header and add PT_LOAD program headers Mahesh J Salgaonkar
2012-02-16 11:14 ` [RFC PATCH v7 05/10] fadump: Convert firmware-assisted cpu state dump data into elf notes Mahesh J Salgaonkar
2012-02-16 11:14 ` [RFC PATCH v7 06/10] fadump: Add PT_NOTE program header for vmcoreinfo Mahesh J Salgaonkar
2012-02-16 11:15 ` Mahesh J Salgaonkar [this message]
2012-02-16 11:15 ` [RFC PATCH v7 08/10] fadump: Invalidate registration and release reserved memory for general use Mahesh J Salgaonkar
2012-02-16 11:15 ` [RFC PATCH v7 09/10] fadump: Invalidate the fadump registration during machine shutdown Mahesh J Salgaonkar
2012-02-16 11:15 ` [RFC PATCH v7 10/10] fadump: Remove the phyp assisted dump code Mahesh J Salgaonkar
2012-02-19 23:47 ` [RFC PATCH v7 00/10] fadump: Firmware-assisted dump support for Powerpc Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216111459.4733.83147.stgit@mars \
--to=mahesh@linux.vnet.ibm.com \
--cc=amwang@redhat.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
--cc=paulus@samba.org \
--cc=rdunlap@xenotime.net \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).