From: Grant Likely <grant.likely@secretlab.ca>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: powerpc/mpic: Fix allocation of reverse-map for multi-ISU mpics
Date: Wed, 22 Feb 2012 18:39:47 -0700 [thread overview]
Message-ID: <20120223013947.GC3212@ponder.secretlab.ca> (raw)
In-Reply-To: <1329954613.20389.15.camel@pasglop>
On Thu, Feb 23, 2012 at 10:50:13AM +1100, Benjamin Herrenschmidt wrote:
> When using a multi-ISU MPIC, we can interrupts up to
> isu_size * MPIC_MAX_ISU, not just isu_size, so allocate
> the right size reverse map.
>
> Without this, the code will constantly fallback to
> a linear search.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Looks fine to me. This will conflict with the irqdomain tree in linux-next,
but it will be a trivial fixup. Still, if you prefer I can pick this
up into my tree.
g.
> ---
>
> diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
> index 4e9ccb1..7fb3ab5 100644
> --- a/arch/powerpc/sysdev/mpic.c
> +++ b/arch/powerpc/sysdev/mpic.c
> @@ -1346,7 +1346,8 @@ struct mpic * __init mpic_alloc(struct device_node *node,
> mpic->isu_mask = (1 << mpic->isu_shift) - 1;
>
> mpic->irqhost = irq_alloc_host(mpic->node, IRQ_HOST_MAP_LINEAR,
> - isu_size ? isu_size : mpic->num_sources,
> + isu_size ? isu_size * MPIC_MAX_ISU :
> + mpic->num_sources,
> &mpic_host_ops,
> flags & MPIC_LARGE_VECTORS ? 2048 : 256);
>
>
>
next prev parent reply other threads:[~2012-02-23 1:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 23:50 powerpc/mpic: Fix allocation of reverse-map for multi-ISU mpics Benjamin Herrenschmidt
2012-02-23 1:39 ` Grant Likely [this message]
2012-02-23 1:55 ` Benjamin Herrenschmidt
2012-02-23 1:59 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120223013947.GC3212@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).