From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] PPC: Don't sync timebase when inside VM
Date: Fri, 2 Mar 2012 10:20:58 -0600 [thread overview]
Message-ID: <20120302162058.GA24552@schlenkerla.am.freescale.net> (raw)
In-Reply-To: <1330697553-27156-1-git-send-email-agraf@suse.de>
On Fri, Mar 02, 2012 at 03:12:33PM +0100, Alexander Graf wrote:
> When running inside a virtual machine, we can not modify timebase, so
> let's just not call the functions for it then.
>
> This resolves hangs when booting e500 SMP guests on overcommitted hosts.
>
> Reported-by: Stuart Yoder <B08248@freescale.com>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> arch/powerpc/platforms/85xx/smp.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/platforms/85xx/smp.c b/arch/powerpc/platforms/85xx/smp.c
> index ff42490..d4b6c1f 100644
> --- a/arch/powerpc/platforms/85xx/smp.c
> +++ b/arch/powerpc/platforms/85xx/smp.c
> @@ -249,6 +249,13 @@ void __init mpc85xx_smp_init(void)
> smp_85xx_ops.cause_ipi = doorbell_cause_ipi;
> }
>
> + /* When running under a hypervisor, we can not modify tb */
> + np = of_find_node_by_path("/hypervisor");
> + if (np) {
> + smp_85xx_ops.give_timebase = NULL;
> + smp_85xx_ops.take_timebase = NULL;
> + }
> +
> smp_ops = &smp_85xx_ops;
Again, for 85xx we should *never* sync the timebase in the kernel,
hypervisor or no.
-Scott
next prev parent reply other threads:[~2012-03-02 16:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 14:12 [PATCH] PPC: Don't sync timebase when inside VM Alexander Graf
2012-03-02 16:20 ` Scott Wood [this message]
2012-03-02 16:30 ` Alexander Graf
2012-03-02 17:17 ` Scott Wood
2012-03-08 17:31 ` McClintock Matthew-B29882
2012-03-08 18:20 ` Scott Wood
2012-03-08 18:24 ` McClintock Matthew-B29882
2012-03-08 18:43 ` Scott Wood
2012-03-08 18:46 ` McClintock Matthew-B29882
2013-07-22 22:19 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120302162058.GA24552@schlenkerla.am.freescale.net \
--to=scottwood@freescale.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).