From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>
Cc: Viresh Kumar <viresh.kumar@st.com>,
Stephen Warren <swarren@nvidia.com>,
Linus Walleij <linus.walleij@stericsson.com>,
Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>,
Zhang Wei <zw@zh-kernel.org>, Barry Song <baohua.song@csr.com>,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/9] DMA engine cookie handling cleanups
Date: Mon, 5 Mar 2012 20:14:11 +0000 [thread overview]
Message-ID: <20120305201411.GA17791@n2100.arm.linux.org.uk> (raw)
This patch series cleans up the handling of cookies in DMA engine drivers.
This is done by providing a set of inline library functions for common
tasks:
- moving the 'last completed cookie' into struct dma_chan - everyone
has this in their driver private channel data structure
- consolidate allocation of cookies to DMA descriptors
- common way to update 'last completed cookie' value
- standard way to implement tx_status callback and update the residue
- consolidate initialization of cookies
- update implementations differing from the majority of DMA engine drivers
to behave the same as the majority implementation in respect of cookies
What this means is that we get to the point where all DMA engine drivers
will hand out cookie value '2' as the first, and incrementing cookie
values up to INT_MAX, returning to cookie '1' as the next cookie.
Think of this patch series as round 1... I am hoping over time that more
code can be consolidated between the DMA engine drivers and end up with a
consistent way to handle various common themes in DMA engine hardware
(like physical channel<->peripheral request signal selection.)
I've only build-tested this stuff on a few ARM configs, and my ability
to run-test this stuff is even more limited by all the broken useless DMA
engine hardware I have access to (mostly pl08x based) so having some
tested-bys would be a great advantage.
Overall, the diffstat looks like this:
arch/arm/include/asm/hardware/iop_adma.h | 2 -
drivers/dma/amba-pl08x.c | 38 ++++---------
drivers/dma/at_hdmac.c | 48 ++++------------
drivers/dma/at_hdmac_regs.h | 2 -
drivers/dma/coh901318.c | 39 +++----------
drivers/dma/dmaengine.h | 89 ++++++++++++++++++++++++++++++
drivers/dma/dw_dmac.c | 43 +++-----------
drivers/dma/dw_dmac_regs.h | 1 -
drivers/dma/ep93xx_dma.c | 25 ++------
drivers/dma/fsldma.c | 24 ++------
drivers/dma/fsldma.h | 1 -
drivers/dma/imx-dma.c | 32 ++---------
drivers/dma/imx-sdma.c | 23 ++------
drivers/dma/intel_mid_dma.c | 37 +++---------
drivers/dma/intel_mid_dma_regs.h | 2 -
drivers/dma/ioat/dma.c | 21 +++----
drivers/dma/ioat/dma.h | 23 --------
drivers/dma/ioat/dma_v2.c | 13 ++---
drivers/dma/ioat/dma_v3.c | 11 ++--
drivers/dma/iop-adma.c | 51 ++++-------------
drivers/dma/ipu/ipu_idmac.c | 22 ++-----
drivers/dma/mpc512x_dma.c | 25 +++------
drivers/dma/mv_xor.c | 34 ++---------
drivers/dma/mv_xor.h | 3 -
drivers/dma/mxs-dma.c | 23 ++------
drivers/dma/pch_dma.c | 34 ++---------
drivers/dma/pl330.c | 36 ++----------
drivers/dma/ppc4xx/adma.c | 49 +++-------------
drivers/dma/ppc4xx/adma.h | 2 -
drivers/dma/shdma.c | 30 +++-------
drivers/dma/shdma.h | 1 -
drivers/dma/sirf-dma.c | 23 ++------
drivers/dma/ste_dma40.c | 36 +++---------
drivers/dma/timb_dma.c | 28 +++-------
drivers/dma/txx9dmac.c | 41 +++-----------
drivers/dma/txx9dmac.h | 1 -
include/linux/amba/pl08x.h | 2 -
include/linux/dmaengine.h | 2 +
38 files changed, 291 insertions(+), 626 deletions(-)
next reply other threads:[~2012-03-05 20:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 20:14 Russell King - ARM Linux [this message]
2012-03-05 20:15 ` [PATCH 2/9] dmaengine: move last completed cookie into generic dma_chan structure Russell King - ARM Linux
2012-03-05 20:15 ` [PATCH 3/9] dmaengine: add private header file Russell King - ARM Linux
2012-03-05 23:28 ` H Hartley Sweeten
2012-03-05 20:16 ` [PATCH 4/9] dmaengine: consolidate assignment of DMA cookies Russell King - ARM Linux
2012-03-05 20:16 ` [PATCH 5/9] dmaengine: provide a common function for completing a dma descriptor Russell King - ARM Linux
2012-03-05 20:16 ` [PATCH 6/9] dmaengine: consolidate tx_status functions Russell King - ARM Linux
2012-03-05 23:35 ` H Hartley Sweeten
2012-03-06 0:12 ` H Hartley Sweeten
2012-03-06 8:59 ` Russell King - ARM Linux
2012-03-05 20:17 ` [PATCH 9/9] dmaengine: ensure all DMA engine drivers initialize their cookies Russell King - ARM Linux
2012-03-05 20:50 ` [PATCH 0/9] DMA engine cookie handling cleanups Linus Walleij
2012-03-05 20:58 ` Russell King - ARM Linux
2012-03-05 23:44 ` H Hartley Sweeten
2012-03-05 23:54 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120305201411.GA17791@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=baohua.song@csr.com \
--cc=dan.j.williams@intel.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=srinidhi.kasagar@stericsson.com \
--cc=swarren@nvidia.com \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@st.com \
--cc=zw@zh-kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).