Re: [PATCH] powerpc/dts: fix the compatible string of sec 4.0

[Kim Phillips <kim.phillips@freescale.com>]

On Tue, 6 Mar 2012 15:21:16 +0800
Shengzhou Liu <Shengzhou.Liu@freescale.com> wrote:

> From: Liu Shuo <shuo.liu@freescale.com>
> 
> Fix the compatible string of sec 4.0 to match with CAMM driver according
> to the documentation file Documentation/devicetree/bindings/crypto/fsl-sec4.txt.

s/the documentation file//, since it's pretty obvious from the
pathname.

Also, if you wrap your commit text to 75 chars, then people won't
have to use the left- and right-arrow keys when browsing git log.

> +++ b/arch/powerpc/boot/dts/fsl/pq3-sec4.4-0.dtsi
> @@ -33,32 +33,32 @@
>   */
>  
>  crypto@30000 {
> -	compatible = "fsl,sec4.4", "fsl,sec4.0";
> +	compatible = "fsl,sec-v4.4", "fsl,sec-v4.0";

so I've tracked the original error down to v3.2-rc3-18-g5652520,
which means v3.2 was released with the error.  Consequently, the
driver should also be updated to check for "fsl,sec-v4.0", and,
failing that, check for "fsl,sec4.0".  The fix should also be sent
to stable@kernel.org [1].

Thanks,

Kim

[1] see Documentation/stable_kernel_rules.txt