From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Stephen Warren <swarren@nvidia.com>,
Linus Walleij <linus.walleij@stericsson.com>,
Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>,
Vinod Koul <vinod.koul@intel.com>,
Barry Song <baohua.song@csr.com>,
Dan Williams <dan.j.williams@intel.com>,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/9] DMA engine cookie handling cleanups
Date: Wed, 7 Mar 2012 18:21:55 +0000 [thread overview]
Message-ID: <20120307182155.GD18787@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CABb+yY0A9=XKuw=N1fFXCB507zR3U=wofqATVcO_wtnnVrgXzQ@mail.gmail.com>
On Wed, Mar 07, 2012 at 11:39:25PM +0530, Jassi Brar wrote:
> Compilation is broken without the following minor fix.
> After that you may add
> Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
>
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index 49c123f..abf35a3 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -339,7 +339,6 @@ static int pl330_control(struct dma_chan *chan,
> enum dma_ctrl_cmd cmd, unsigned
> /* Mark all desc done */
> list_for_each_entry_safe(desc, _dt, &pch->work_list , node) {
> desc->status = DONE;
> - pch->completed = desc->txd.cookie;
I'm not sure just removing this is sufficient. Presumably it's
there for some reason - maybe it needs replacing with a call to
dma_cookie_complete() to preserve existing behaviour?
next prev parent reply other threads:[~2012-03-07 18:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 22:33 [PATCH v2 0/9] DMA engine cookie handling cleanups Russell King - ARM Linux
2012-03-06 22:34 ` [PATCH 2/9] dmaengine: move last completed cookie into generic dma_chan structure Russell King - ARM Linux
2012-03-07 0:38 ` H Hartley Sweeten
2012-03-06 22:34 ` [PATCH 3/9] dmaengine: add private header file Russell King - ARM Linux
2012-03-07 0:47 ` H Hartley Sweeten
2012-03-06 22:34 ` [PATCH 4/9] dmaengine: consolidate assignment of DMA cookies Russell King - ARM Linux
2012-03-07 0:53 ` H Hartley Sweeten
2012-03-06 22:35 ` [PATCH 5/9] dmaengine: provide a common function for completing a dma descriptor Russell King - ARM Linux
2012-03-07 0:56 ` H Hartley Sweeten
2012-04-23 9:40 ` Boojin Kim
2012-04-23 9:50 ` Russell King - ARM Linux
2012-04-23 10:01 ` Vinod Koul
2012-04-23 11:06 ` Boojin Kim
2012-04-23 11:13 ` Russell King - ARM Linux
2012-03-06 22:35 ` [PATCH 6/9] dmaengine: consolidate tx_status functions Russell King - ARM Linux
2012-03-07 1:04 ` H Hartley Sweeten
2012-03-06 22:36 ` [PATCH 9/9] dmaengine: ensure all DMA engine drivers initialize their cookies Russell King - ARM Linux
2012-03-07 8:33 ` [PATCH v2 0/9] DMA engine cookie handling cleanups Linus Walleij
2012-03-07 9:06 ` Russell King - ARM Linux
2012-03-07 13:54 ` Vinod Koul
2012-03-12 16:11 ` Russell King - ARM Linux
2012-03-12 16:23 ` Vinod Koul
2012-03-13 8:40 ` Vinod Koul
2012-03-13 12:31 ` Russell King - ARM Linux
2012-03-13 14:38 ` Vinod Koul
2012-03-19 14:35 ` Vinod Koul
2012-03-07 18:09 ` Jassi Brar
2012-03-07 18:21 ` Russell King - ARM Linux [this message]
2012-03-07 18:44 ` Jassi Brar
2012-03-09 8:59 ` Shawn Guo
2012-03-13 11:45 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120307182155.GD18787@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=baohua.song@csr.com \
--cc=dan.j.williams@intel.com \
--cc=jassisinghbrar@gmail.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=srinidhi.kasagar@stericsson.com \
--cc=swarren@nvidia.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).