From: Grant Likely <grant.likely@secretlab.ca>
To: Timur Tabi <timur@freescale.com>, Kumar Gala <galak@kernel.crashing.org>
Cc: Scott Wood <scottwood@freescale.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice
Date: Mon, 19 Mar 2012 16:04:52 +0000 [thread overview]
Message-ID: <20120319160452.B57D13E05A5@localhost> (raw)
In-Reply-To: <4F63A7A4.4000205@freescale.com>
On Fri, 16 Mar 2012 15:50:44 -0500, Timur Tabi <timur@freescale.com> wrote:
> Kumar Gala wrote:
>
> > This seems like paper taping over the real issue. We should be able to call of_platform_bus_probe() multiple times.
>
> I tried debugging it, but I couldn't figure it out. My guess is that the
> nodes probed by of_platform_bus_probe() are somehow "reserved", so that
> the second time it's called, they're skipped. I figured that this was
> just a side-effect of the way the OF layer works.
The problem is that you want to create devices for grandchildren
nodes when the bus ids passed in don't match any of the child nodes so
the of_platform_bus_probe() doesn't iterate down to that level. This
is correct and expected behaviour.
g.
next prev parent reply other threads:[~2012-03-19 16:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 16:19 [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice Timur Tabi
2012-03-07 21:41 ` Timur Tabi
2012-03-16 20:46 ` Kumar Gala
2012-03-16 20:50 ` Timur Tabi
2012-03-19 16:04 ` Grant Likely [this message]
2012-03-19 18:43 ` Timur Tabi
2012-03-20 17:09 ` Grant Likely
2012-03-20 17:25 ` Timur Tabi
2012-03-21 15:15 ` Timur Tabi
2012-03-27 18:18 ` Timur Tabi
2012-03-28 5:01 ` Grant Likely
2012-03-21 15:08 ` Kumar Gala
2012-04-19 20:15 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120319160452.B57D13E05A5@localhost \
--to=grant.likely@secretlab.ca \
--cc=dbaryshkov@gmail.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).