From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net (shards.monkeyblade.net [198.137.202.13]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5F745B703E for ; Sat, 12 May 2012 08:07:38 +1000 (EST) Date: Fri, 11 May 2012 18:03:28 -0400 (EDT) Message-Id: <20120511.180328.1412689186292656882.davem@davemloft.net> To: ddaney.cavm@gmail.com Subject: Re: [PATCH] net: of/phy: fix build error when phylib is built as a module From: David Miller In-Reply-To: <4FAD532E.401@gmail.com> References: <20120510.224352.2149006669429730060.davem@davemloft.net> <1336751221-19127-1-git-send-email-bjorn@mork.no> <4FAD532E.401@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Cc: sfr@canb.auug.org.au, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com, rdunlap@xenotime.net, linux-next@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, bjorn@mork.no List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: David Daney Date: Fri, 11 May 2012 10:58:06 -0700 > On 05/11/2012 08:47 AM, Bj=F8rn Mork wrote: >> CONFIG_OF_MDIO is tristate and will be m if PHYLIB is m. Use >> IS_ENABLED macro to prevent build error: >> >> ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined!= >> >> Reported-by: Randy Dunlap >> Cc: David Daney >> Signed-off-by: Bj=F8rn Mork > = > I was able to reproduce the failure, and this patch both fixes it and= > seems correct, so... > = > Acked-by: David Daney Applied.