* Re: linux-next: Tree for May 10 (net/phy) [not found] ` <4FAC35E2.4060900@xenotime.net> @ 2012-05-11 2:36 ` Paul Gortmaker 2012-05-11 2:43 ` David Miller 0 siblings, 1 reply; 8+ messages in thread From: Paul Gortmaker @ 2012-05-11 2:36 UTC (permalink / raw) To: Randy Dunlap; +Cc: Stephen Rothwell, linux-next, linuxppc-dev, LKML, netdev On Thu, May 10, 2012 at 5:40 PM, Randy Dunlap <rdunlap@xenotime.net> wrote: > On 05/10/2012 02:26 AM, Stephen Rothwell wrote: > >> Hi all, >> >> Changes since 20120508: > > > > ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined! Not just randconfig, but also powerpc allmodconfig: http://kisskb.ellerman.id.au/kisskb/buildresult/6291463/ Adding ppc ML to cc. P. -- > > Full randconfig file is attached. > > -- > ~Randy ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for May 10 (net/phy) 2012-05-11 2:36 ` linux-next: Tree for May 10 (net/phy) Paul Gortmaker @ 2012-05-11 2:43 ` David Miller 2012-05-11 15:47 ` [PATCH] net: of/phy: fix build error when phylib is built as a module Bjørn Mork 2012-05-11 16:14 ` linux-next: Tree for May 10 (net/phy) David Daney 0 siblings, 2 replies; 8+ messages in thread From: David Miller @ 2012-05-11 2:43 UTC (permalink / raw) To: paul.gortmaker Cc: sfr, david.daney, netdev, linux-kernel, rdunlap, linux-next, linuxppc-dev From: Paul Gortmaker <paul.gortmaker@windriver.com> Date: Thu, 10 May 2012 22:36:55 -0400 > On Thu, May 10, 2012 at 5:40 PM, Randy Dunlap <rdunlap@xenotime.net> wrote: >> On 05/10/2012 02:26 AM, Stephen Rothwell wrote: >> >>> Hi all, >>> >>> Changes since 20120508: >> >> >> >> ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined! > > Not just randconfig, but also powerpc allmodconfig: > > http://kisskb.ellerman.id.au/kisskb/buildresult/6291463/ > > Adding ppc ML to cc. Adding the guilty party to the CC:. This really stinks, especially after I did give the patch submitter a hard time about getting the dependencies right. :-/ ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] net: of/phy: fix build error when phylib is built as a module 2012-05-11 2:43 ` David Miller @ 2012-05-11 15:47 ` Bjørn Mork 2012-05-11 17:58 ` David Daney ` (2 more replies) 2012-05-11 16:14 ` linux-next: Tree for May 10 (net/phy) David Daney 1 sibling, 3 replies; 8+ messages in thread From: Bjørn Mork @ 2012-05-11 15:47 UTC (permalink / raw) To: David Miller Cc: sfr, david.daney, netdev, linux-kernel, paul.gortmaker, rdunlap, linux-next, linuxppc-dev, Bjørn Mork CONFIG_OF_MDIO is tristate and will be m if PHYLIB is m. Use IS_ENABLED macro to prevent build error: ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined! Reported-by: Randy Dunlap <rdunlap@xenotime.net> Cc: David Daney <david.daney@cavium.com> Signed-off-by: Bjørn Mork <bjorn@mork.no> --- I wonder if this could be as banal as this? Not even build tested... Should be wrapped into commit 25106022 if it works, to ensure bisectability. Bjørn drivers/net/phy/mdio_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 83d5c9f..683ef1c 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -88,7 +88,7 @@ static struct class mdio_bus_class = { .dev_release = mdiobus_release, }; -#ifdef CONFIG_OF_MDIO +#if IS_ENABLED(CONFIG_OF_MDIO) /* Helper function for of_mdio_find_bus */ static int of_mdio_bus_match(struct device *dev, void *mdio_bus_np) { -- 1.7.10 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] net: of/phy: fix build error when phylib is built as a module 2012-05-11 15:47 ` [PATCH] net: of/phy: fix build error when phylib is built as a module Bjørn Mork @ 2012-05-11 17:58 ` David Daney 2012-05-11 22:03 ` David Miller 2012-05-11 21:24 ` David Miller 2012-05-11 23:50 ` Randy Dunlap 2 siblings, 1 reply; 8+ messages in thread From: David Daney @ 2012-05-11 17:58 UTC (permalink / raw) To: Bjørn Mork, David Miller Cc: sfr@canb.auug.org.au, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com, rdunlap@xenotime.net, linux-next@vger.kernel.org, linuxppc-dev@lists.ozlabs.org On 05/11/2012 08:47 AM, Bjørn Mork wrote: > CONFIG_OF_MDIO is tristate and will be m if PHYLIB is m. Use > IS_ENABLED macro to prevent build error: > > ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined! > > Reported-by: Randy Dunlap<rdunlap@xenotime.net> > Cc: David Daney<david.daney@cavium.com> > Signed-off-by: Bjørn Mork<bjorn@mork.no> I was able to reproduce the failure, and this patch both fixes it and seems correct, so... Acked-by: David Daney<david.daney@cavium.com> Sorry about this failure. > --- > I wonder if this could be as banal as this? Not even build tested... > > Should be wrapped into commit 25106022 if it works, to ensure > bisectability. > > > > Bjørn > > drivers/net/phy/mdio_bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c > index 83d5c9f..683ef1c 100644 > --- a/drivers/net/phy/mdio_bus.c > +++ b/drivers/net/phy/mdio_bus.c > @@ -88,7 +88,7 @@ static struct class mdio_bus_class = { > .dev_release = mdiobus_release, > }; > > -#ifdef CONFIG_OF_MDIO > +#if IS_ENABLED(CONFIG_OF_MDIO) > /* Helper function for of_mdio_find_bus */ > static int of_mdio_bus_match(struct device *dev, void *mdio_bus_np) > { ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] net: of/phy: fix build error when phylib is built as a module 2012-05-11 17:58 ` David Daney @ 2012-05-11 22:03 ` David Miller 0 siblings, 0 replies; 8+ messages in thread From: David Miller @ 2012-05-11 22:03 UTC (permalink / raw) To: ddaney.cavm Cc: sfr, netdev, linux-kernel, paul.gortmaker, rdunlap, linux-next, linuxppc-dev, bjorn From: David Daney <ddaney.cavm@gmail.com> Date: Fri, 11 May 2012 10:58:06 -0700 > On 05/11/2012 08:47 AM, Bj=F8rn Mork wrote: >> CONFIG_OF_MDIO is tristate and will be m if PHYLIB is m. Use >> IS_ENABLED macro to prevent build error: >> >> ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined!= >> >> Reported-by: Randy Dunlap<rdunlap@xenotime.net> >> Cc: David Daney<david.daney@cavium.com> >> Signed-off-by: Bj=F8rn Mork<bjorn@mork.no> > = > I was able to reproduce the failure, and this patch both fixes it and= > seems correct, so... > = > Acked-by: David Daney<david.daney@cavium.com> Applied. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] net: of/phy: fix build error when phylib is built as a module 2012-05-11 15:47 ` [PATCH] net: of/phy: fix build error when phylib is built as a module Bjørn Mork 2012-05-11 17:58 ` David Daney @ 2012-05-11 21:24 ` David Miller 2012-05-11 23:50 ` Randy Dunlap 2 siblings, 0 replies; 8+ messages in thread From: David Miller @ 2012-05-11 21:24 UTC (permalink / raw) To: bjorn Cc: sfr, david.daney, netdev, linux-kernel, paul.gortmaker, rdunlap, linux-next, linuxppc-dev From: Bj=F8rn Mork <bjorn@mork.no> Date: Fri, 11 May 2012 17:47:01 +0200 > Should be wrapped into commit 25106022 if it works, to ensure > bisectability. Wrapped into? Commits made to my net-next tree are permanent and irreversible, so we cannot go back and change a commit. I never rebase my tree, too many people use it directly and pull it into their tree, so I'd break their world if I ever did that. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] net: of/phy: fix build error when phylib is built as a module 2012-05-11 15:47 ` [PATCH] net: of/phy: fix build error when phylib is built as a module Bjørn Mork 2012-05-11 17:58 ` David Daney 2012-05-11 21:24 ` David Miller @ 2012-05-11 23:50 ` Randy Dunlap 2 siblings, 0 replies; 8+ messages in thread From: Randy Dunlap @ 2012-05-11 23:50 UTC (permalink / raw) To: Bjørn Mork Cc: sfr, david.daney, netdev, linux-kernel, paul.gortmaker, linux-next, linuxppc-dev, David Miller On 05/11/2012 08:47 AM, Bjørn Mork wrote: > CONFIG_OF_MDIO is tristate and will be m if PHYLIB is m. Use > IS_ENABLED macro to prevent build error: > > ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined! > > Reported-by: Randy Dunlap <rdunlap@xenotime.net> > Cc: David Daney <david.daney@cavium.com> > Signed-off-by: Bjørn Mork <bjorn@mork.no> Acked-by: Randy Dunlap <rdunlap@xenotime.net> Thanks. > --- > I wonder if this could be as banal as this? Not even build tested... > > Should be wrapped into commit 25106022 if it works, to ensure > bisectability. > > > > Bjørn > > drivers/net/phy/mdio_bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c > index 83d5c9f..683ef1c 100644 > --- a/drivers/net/phy/mdio_bus.c > +++ b/drivers/net/phy/mdio_bus.c > @@ -88,7 +88,7 @@ static struct class mdio_bus_class = { > .dev_release = mdiobus_release, > }; > > -#ifdef CONFIG_OF_MDIO > +#if IS_ENABLED(CONFIG_OF_MDIO) > /* Helper function for of_mdio_find_bus */ > static int of_mdio_bus_match(struct device *dev, void *mdio_bus_np) > { -- ~Randy ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for May 10 (net/phy) 2012-05-11 2:43 ` David Miller 2012-05-11 15:47 ` [PATCH] net: of/phy: fix build error when phylib is built as a module Bjørn Mork @ 2012-05-11 16:14 ` David Daney 1 sibling, 0 replies; 8+ messages in thread From: David Daney @ 2012-05-11 16:14 UTC (permalink / raw) To: David Miller Cc: sfr@canb.auug.org.au, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com, rdunlap@xenotime.net, linux-next@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Bjørn Mork On 05/10/2012 07:43 PM, David Miller wrote: > From: Paul Gortmaker<paul.gortmaker@windriver.com> > Date: Thu, 10 May 2012 22:36:55 -0400 > >> On Thu, May 10, 2012 at 5:40 PM, Randy Dunlap<rdunlap@xenotime.net> wrote: >>> On 05/10/2012 02:26 AM, Stephen Rothwell wrote: >>> >>>> Hi all, >>>> >>>> Changes since 20120508: >>> >>> >>> >>> ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined! >> >> Not just randconfig, but also powerpc allmodconfig: >> >> http://kisskb.ellerman.id.au/kisskb/buildresult/6291463/ >> >> Adding ppc ML to cc. > > Adding the guilty party to the CC:. This really stinks, especially > after I did give the patch submitter a hard time about getting the > dependencies right. :-/ Indeed, how embarrassing. It looks like Bjørn may have already posted a fix. I will try to verify that it works, and take appropriate action. Sorry about the screw up, David Daney ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-05-11 23:50 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20120510192635.c6f3a55196bbf65f13956e44@canb.auug.org.au>
[not found] ` <4FAC35E2.4060900@xenotime.net>
2012-05-11 2:36 ` linux-next: Tree for May 10 (net/phy) Paul Gortmaker
2012-05-11 2:43 ` David Miller
2012-05-11 15:47 ` [PATCH] net: of/phy: fix build error when phylib is built as a module Bjørn Mork
2012-05-11 17:58 ` David Daney
2012-05-11 22:03 ` David Miller
2012-05-11 21:24 ` David Miller
2012-05-11 23:50 ` Randy Dunlap
2012-05-11 16:14 ` linux-next: Tree for May 10 (net/phy) David Daney
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).