From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@au1.ibm.com>,
linuxppc-dev@lists.ozlabs.org, Wang Sheng-Hui <shhuiw@gmail.com>
Subject: Re: [PATCH] powerpc/irq: Fix another case of lazy IRQ state getting out of sync
Date: Fri, 11 May 2012 10:04:39 -0700 [thread overview]
Message-ID: <20120511170439.GA19856@us.ibm.com> (raw)
In-Reply-To: <1336702358.3881.77.camel@pasglop>
Benjamin Herrenschmidt [benh@kernel.crashing.org] wrote:
| So we have another case of paca->irq_happened getting out of
| sync with the HW irq state. This can happen when a perfmon
| interrupt occurs while soft disabled, as it will return to a
| soft disabled but hard enabled context while leaving a stale
| PACA_IRQ_HARD_DIS flag set.
|
| This patch fixes it, and also adds a test for the condition
| of those flags being out of sync in arch_local_irq_restore()
| when CONFIG_TRACE_IRQFLAGS is enabled.
|
| This helps catching those gremlins faster (and so far I
| can't seem see any anymore, so that's good news).
|
| Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
| ---
|
| Please test ASAP as I need to send that to Linus today
Works for me. I was able to run my script over a 100 times. Without
the patch, it fails reliably first or second attempt.
Thanks for fixing it quickly.
Sukadev
next prev parent reply other threads:[~2012-05-11 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 0:23 [BUG] powerpc: perf record crash Sukadev Bhattiprolu
2012-05-11 0:37 ` Benjamin Herrenschmidt
2012-05-11 2:12 ` [PATCH] powerpc/irq: Fix another case of lazy IRQ state getting out of sync Benjamin Herrenschmidt
2012-05-11 17:04 ` Sukadev Bhattiprolu [this message]
2012-05-14 0:53 ` Wang Sheng-Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120511170439.GA19856@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@au1.ibm.com \
--cc=shhuiw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).