From: "Ira W. Snyder" <iws@ovro.caltech.edu>
To: Guillaume Dargaud <dargaud@lpsc.in2p3.fr>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: Replacement to of_register_platform_driver ?
Date: Wed, 13 Jun 2012 10:47:35 -0700 [thread overview]
Message-ID: <20120613174734.GA4846@ovro.caltech.edu> (raw)
In-Reply-To: <4FD8AFF2.6000702@lpsc.in2p3.fr>
On Wed, Jun 13, 2012 at 05:21:22PM +0200, Guillaume Dargaud wrote:
> Hello all,
> I just updated to the most recent kernel and a driver I wrote last year
> won't compile:
> xad.c:534:2: error: implicit declaration of function
> 'of_register_platform_driver'
>
> I see references to this function as 'obsolete' but could not find
> what's the new recommended way to do things. Here's a bit of the
> offending code:
>
> static struct of_platform_driver xad_driver = {
> .probe = xad_driver_probe,
> .remove = xad_driver_remove,
> .driver = {
> .owner = THIS_MODULE,
> .name = "xad-driver",
> .of_match_table = xad_device_id,
> },
> };
>
> ...
>
> static int __init xad_init(void) {
> ...
> first = MKDEV (my_major, my_minor);
> register_chrdev_region(first, count, DEVNAME);
> my_cdev = cdev_alloc ();
> if (NULL==my_cdev) goto Err;
>
> cdev_init(my_cdev, &fops);
> rc=cdev_add (my_cdev, first, count);
> ...
> rc = of_register_platform_driver(&xad_driver);
> ...
> }
>
>
> --
> Guillaume Dargaud
> http://www.gdargaud.net/
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
The history of drivers/misc/carma/carma-fpga.c will show you the code
changes necessary. Specifically, these two commits perform the
conversion:
493340207 carma-fpga: Missed switch from of_register_platform_driver()
b00e126ff MISC: convert drivers/misc/* to use module_platform_driver()
Hope it helps,
Ira
next prev parent reply other threads:[~2012-06-13 17:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 15:21 Replacement to of_register_platform_driver ? Guillaume Dargaud
2012-06-13 17:47 ` Ira W. Snyder [this message]
2012-06-14 0:28 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613174734.GA4846@ovro.caltech.edu \
--to=iws@ovro.caltech.edu \
--cc=dargaud@lpsc.in2p3.fr \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).