linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Gavin Shan <shangw@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
	Yinghai Lu <yinghai@kernel.org>,
	Gavin Shan <shangw@linux.vnet.ibm.com>,
	linuxppc-dev@ozlabs.org
Subject: Re: [PATCH V3 1/2] PCI: retrieve host bridge by PCI bus
Date: Tue, 26 Jun 2012 11:01:11 +0800	[thread overview]
Message-ID: <20120626030111.GA6753@shangw> (raw)
In-Reply-To: <1340679045.3732.3.camel@pasglop>

>> >> +EXPORT_SYMBOL(pci_bus_host_bridge);
>> 
>> Yinghai, thanks for your time on this :-)
>> 
>> >
>> >why do you need to export it?
>> >
>> 
>> The reason is that we have introduced extra fields to "struct
>> pci_host_bridge"
>> in [PATCH 2/2] and platform want to access those extra fields. 
>
>But the platform code is built-in, not modular, so it doesn't need
>EXPORT_SYMBOL (additionally even if we wanted to export it we probably
>also want it _GPL only, so EXPORT_SYMBOL_GPL, but I don't think we need
>to).
>

Ben, thanks for correcting me :-)

Let me remove EXPORT_SYMBOL() is next revision.

>Cheers,
>Ben.
>
>

Thanks,
Gavin

  reply	other threads:[~2012-06-26  3:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-25  3:10 [PATCH V3 1/2] PCI: retrieve host bridge by PCI bus Gavin Shan
2012-06-25  3:10 ` [PATCH V3 2/2] PCI: minimal alignment for bars of P2P bridges Gavin Shan
2012-06-25 17:30 ` [PATCH V3 1/2] PCI: retrieve host bridge by PCI bus Yinghai Lu
2012-06-26  0:30   ` Gavin Shan
2012-06-26  2:50     ` Benjamin Herrenschmidt
2012-06-26  3:01       ` Gavin Shan [this message]
2012-06-26 18:29     ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120626030111.GA6753@shangw \
    --to=shangw@linux.vnet.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).