From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Gabriel Paubert <paubert@iram.es>
Cc: michaele@au1.ibm.com, Anton Blanchard <anton@au1.ibm.com>,
sukadev@us.ibm.com, linuxppc-dev@ozlabs.org,
cel@linux.vnet.ibm.com, khandual@linux.vnet.ibm.com
Subject: Re: [PATCH 1/2] power: Define PV_POWER7P
Date: Mon, 16 Jul 2012 14:25:51 -0700 [thread overview]
Message-ID: <20120716212551.GA14163@us.ibm.com> (raw)
In-Reply-To: <20120713064605.GA11030@visitor2.iram.es>
Gabriel Paubert [paubert@iram.es] wrote:
| > +#define PV_POWER7P 0x004A
| > #define PV_630 0x0040
| > #define PV_630p 0x0041
| > #define PV_970MP 0x0044
|
| Hmm, before this patch the PVR definitions were sorted in ascending
| numerical order, at least for the list of 64 bit processors. Your
| patch breaks this, which is not a good idea IMHO.
|
| For example, the 970* processors are already interspersed with other
| processors to maintain numerical order, therefore I don't see why the
| POWER7P could not be between 970GX and BE.
|
| Another inconsistency is that all other "plus" variants seem to
| use a lower case "p" suffix. So it would be better to use POWER7p.
Agree with both your points above. I re-sent the patches with updates.
Sukadev
prev parent reply other threads:[~2012-07-16 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 23:59 [PATCH 1/2] power: Define PV_POWER7P Sukadev Bhattiprolu
2012-07-13 0:00 ` [PATCH 2/2] [perf][power]: Sample only if SIAR-Valid bit is set in P7+ Sukadev Bhattiprolu
2012-07-13 6:46 ` [PATCH 1/2] power: Define PV_POWER7P Gabriel Paubert
2012-07-16 21:25 ` Sukadev Bhattiprolu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120716212551.GA14163@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=anton@au1.ibm.com \
--cc=cel@linux.vnet.ibm.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michaele@au1.ibm.com \
--cc=paubert@iram.es \
--cc=sukadev@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).