From: Greg KH <gregkh@linuxfoundation.org>
To: sandeep@freescale.com
Cc: devel@driverdev.osuosl.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [2/3][PATCH][v2] TDM Framework
Date: Fri, 27 Jul 2012 11:12:08 -0700 [thread overview]
Message-ID: <20120727181208.GC23105@kroah.com> (raw)
In-Reply-To: <1343397940-12975-1-git-send-email-sandeep@freescale.com>
On Fri, Jul 27, 2012 at 07:35:38PM +0530, sandeep@freescale.com wrote:
> +static struct kobj_type tdm_type = {
> + .sysfs_ops = &tdm_ops,
> + .default_attrs = tdm_attr,
> +};
Ah, also, as per the documentation in the kernel (go look, it's there),
I now get to publicly mock you for ignoring the error messages that
the kernel is giving you when you try to shut down your code path.
Well, to be fair, you are leaking memory like a sieve, so I doubt you
ever saw those error messages because you never cleaned up after
yourself, so perhaps I can forgive you, but your users can't, sorry.
They like to rely on the fact that Linux is a reliable operating system,
don't cause them to doubt that.
Please fix this code, it's horribly broken. Read
Documentation/kobject.txt for why. That file was written for a reason,
and not just because we like writing documentation (hint, we hate to...)
Ugh,
greg k-h
next prev parent reply other threads:[~2012-07-27 18:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 14:05 [2/3][PATCH][v2] TDM Framework sandeep
2012-07-27 14:05 ` [1/3][PATCH][v2] Adding documentation for TDM sandeep
2012-07-27 14:05 ` [3/3][PATCH][v2] Added TDM device support and Freescale Starlite driver sandeep
2012-07-27 14:11 ` [2/3][PATCH][v2] TDM Framework John Stoffel
2012-07-30 9:29 ` Singh Sandeep-B37400
2012-07-30 14:10 ` John Stoffel
2012-07-31 6:40 ` Singh Sandeep-B37400
2012-07-27 14:51 ` Russell King - ARM Linux
2012-07-30 13:00 ` Singh Sandeep-B37400
2012-07-27 15:25 ` Francois Romieu
2012-07-30 9:50 ` Singh Sandeep-B37400
2012-07-30 16:01 ` Greg KH
2012-08-01 12:13 ` Singh Sandeep-B37400
2012-08-01 12:37 ` Greg KH
2012-08-21 14:13 ` Mark Brown
2012-07-30 15:45 ` Mark Brown
2012-07-31 6:41 ` Singh Sandeep-B37400
2012-07-27 17:59 ` Greg KH
2012-07-30 9:10 ` Aggrwal Poonam-B10812
2012-07-30 16:04 ` Greg KH
2012-07-27 18:12 ` Greg KH [this message]
2012-07-30 9:13 ` Aggrwal Poonam-B10812
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120727181208.GC23105@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sandeep@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).