From: "Ira W. Snyder" <iws@ovro.caltech.edu>
To: Timur Tabi <timur@freescale.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
qiang.liu@freescale.com, herbert@gondor.hengli.com.au,
linux-crypto@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
linuxppc-dev@lists.ozlabs.org, davem@davemloft.net
Subject: Re: [linuxppc-release] [PATCH v4 7/7] fsl-dma: add memcpy self test interface
Date: Mon, 30 Jul 2012 11:33:23 -0700 [thread overview]
Message-ID: <20120730183322.GA32504@ovro.caltech.edu> (raw)
In-Reply-To: <5016C8F9.7070801@freescale.com>
On Mon, Jul 30, 2012 at 12:48:41PM -0500, Timur Tabi wrote:
> qiang.liu@freescale.com wrote:
> >
> > Add memory copy self test when probe device, fsl-dma will be disabled
> > if self test failed.
>
> Is this a real problem that can occur? The DMA driver used to have a
> self-test, but I removed it a long time ago because it was pointless. I
> don't see why we need to add another one back in.
>
> --
> Timur Tabi
> Linux kernel developer at Freescale
>
I made a comment that a test suite for the async_tx API would be very
helpful in diagnosing similar problems in this and other DMA drivers.
Something standalone, similar to the drivers/dma/dmatest.c driver, using
the async_tx API.
I think this was misinterpreted into me asking that the driver have a
built-in self test.
Ira
next prev parent reply other threads:[~2012-07-30 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 9:16 [PATCH v4 7/7] fsl-dma: add memcpy self test interface qiang.liu
2012-07-30 17:48 ` [linuxppc-release] " Timur Tabi
2012-07-30 18:33 ` Ira W. Snyder [this message]
2012-07-31 2:47 ` Liu Qiang-B32616
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120730183322.GA32504@ovro.caltech.edu \
--to=iws@ovro.caltech.edu \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qiang.liu@freescale.com \
--cc=timur@freescale.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).