* [PATCH] powerpc: dts: 52xx: drop critical IRQ from dts files
@ 2012-08-23 15:31 Wolfram Sang
2012-08-23 15:59 ` Grant Likely
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2012-08-23 15:31 UTC (permalink / raw)
To: linuxppc-dev; +Cc: John Bonesio, Anatolij Gustschin, Wolfram Sang
The wakeup-gpios have been assigned a critical IRQ in current
devicetrees. The PIC driver does not support critical IRQs, though, which
leads to the following error when booting (a PCM030 in this case):
mpc52xx_irqhost_map: invalid irq: virq=16, l1=0, l2=3
irq: irq-16==>hwirq-0x3 mapping failed: -22
[WARNing skipped]
Remove these entries until they are supported, if ever.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: John Bonesio <bones@secretlab.ca>
Cc: Anatolij Gustschin <agust@denx.de>
---
arch/powerpc/boot/dts/lite5200.dts | 2 +-
arch/powerpc/boot/dts/mpc5200b.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/boot/dts/lite5200.dts b/arch/powerpc/boot/dts/lite5200.dts
index 179a178..25adace 100644
--- a/arch/powerpc/boot/dts/lite5200.dts
+++ b/arch/powerpc/boot/dts/lite5200.dts
@@ -141,7 +141,7 @@
gpio@c00 {
compatible = "fsl,mpc5200-gpio-wkup";
reg = <0xc00 0x40>;
- interrupts = <1 8 0 0 3 0>;
+ interrupts = <1 8 0>;
gpio-controller;
#gpio-cells = <2>;
};
diff --git a/arch/powerpc/boot/dts/mpc5200b.dtsi b/arch/powerpc/boot/dts/mpc5200b.dtsi
index 7ab286a..e610d68 100644
--- a/arch/powerpc/boot/dts/mpc5200b.dtsi
+++ b/arch/powerpc/boot/dts/mpc5200b.dtsi
@@ -141,7 +141,7 @@
gpio_wkup: gpio@c00 {
compatible = "fsl,mpc5200b-gpio-wkup","fsl,mpc5200-gpio-wkup";
reg = <0xc00 0x40>;
- interrupts = <1 8 0 0 3 0>;
+ interrupts = <1 8 0>;
gpio-controller;
#gpio-cells = <2>;
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc: dts: 52xx: drop critical IRQ from dts files
2012-08-23 15:31 [PATCH] powerpc: dts: 52xx: drop critical IRQ from dts files Wolfram Sang
@ 2012-08-23 15:59 ` Grant Likely
2012-08-24 8:44 ` Wolfram Sang
0 siblings, 1 reply; 3+ messages in thread
From: Grant Likely @ 2012-08-23 15:59 UTC (permalink / raw)
To: Wolfram Sang; +Cc: John Bonesio, linuxppc-dev, Anatolij Gustschin
On Thu, Aug 23, 2012 at 4:31 PM, Wolfram Sang <w.sang@pengutronix.de> wrote:
> The wakeup-gpios have been assigned a critical IRQ in current
> devicetrees. The PIC driver does not support critical IRQs, though, which
> leads to the following error when booting (a PCM030 in this case):
>
> mpc52xx_irqhost_map: invalid irq: virq=16, l1=0, l2=3
> irq: irq-16==>hwirq-0x3 mapping failed: -22
> [WARNing skipped]
>
> Remove these entries until they are supported, if ever.
The warning is a bug since the irq specifier is valid. Removing the
irqs from the .dts files isn't the solution.
g.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: John Bonesio <bones@secretlab.ca>
> Cc: Anatolij Gustschin <agust@denx.de>
> ---
> arch/powerpc/boot/dts/lite5200.dts | 2 +-
> arch/powerpc/boot/dts/mpc5200b.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/lite5200.dts b/arch/powerpc/boot/dts/lite5200.dts
> index 179a178..25adace 100644
> --- a/arch/powerpc/boot/dts/lite5200.dts
> +++ b/arch/powerpc/boot/dts/lite5200.dts
> @@ -141,7 +141,7 @@
> gpio@c00 {
> compatible = "fsl,mpc5200-gpio-wkup";
> reg = <0xc00 0x40>;
> - interrupts = <1 8 0 0 3 0>;
> + interrupts = <1 8 0>;
> gpio-controller;
> #gpio-cells = <2>;
> };
> diff --git a/arch/powerpc/boot/dts/mpc5200b.dtsi b/arch/powerpc/boot/dts/mpc5200b.dtsi
> index 7ab286a..e610d68 100644
> --- a/arch/powerpc/boot/dts/mpc5200b.dtsi
> +++ b/arch/powerpc/boot/dts/mpc5200b.dtsi
> @@ -141,7 +141,7 @@
> gpio_wkup: gpio@c00 {
> compatible = "fsl,mpc5200b-gpio-wkup","fsl,mpc5200-gpio-wkup";
> reg = <0xc00 0x40>;
> - interrupts = <1 8 0 0 3 0>;
> + interrupts = <1 8 0>;
> gpio-controller;
> #gpio-cells = <2>;
> };
> --
> 1.7.10.4
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc: dts: 52xx: drop critical IRQ from dts files
2012-08-23 15:59 ` Grant Likely
@ 2012-08-24 8:44 ` Wolfram Sang
0 siblings, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2012-08-24 8:44 UTC (permalink / raw)
To: Grant Likely; +Cc: John Bonesio, linuxppc-dev, Anatolij Gustschin
[-- Attachment #1: Type: text/plain, Size: 948 bytes --]
On Thu, Aug 23, 2012 at 04:59:26PM +0100, Grant Likely wrote:
> On Thu, Aug 23, 2012 at 4:31 PM, Wolfram Sang <w.sang@pengutronix.de> wrote:
> > The wakeup-gpios have been assigned a critical IRQ in current
> > devicetrees. The PIC driver does not support critical IRQs, though, which
> > leads to the following error when booting (a PCM030 in this case):
> >
> > mpc52xx_irqhost_map: invalid irq: virq=16, l1=0, l2=3
> > irq: irq-16==>hwirq-0x3 mapping failed: -22
> > [WARNing skipped]
> >
> > Remove these entries until they are supported, if ever.
>
> The warning is a bug since the irq specifier is valid. Removing the
> irqs from the .dts files isn't the solution.
Adding another warning (not error) that critical IRQ are not supported
is?
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-24 8:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-23 15:31 [PATCH] powerpc: dts: 52xx: drop critical IRQ from dts files Wolfram Sang
2012-08-23 15:59 ` Grant Likely
2012-08-24 8:44 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).