From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Rob Herring <rob.herring@calxeda.com>,
kernel@pengutronix.de, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 13/25] macintosh/mediabay: add a const qualifier
Date: Wed, 5 Sep 2012 10:02:49 +0200 [thread overview]
Message-ID: <20120905080249.GI28643@pengutronix.de> (raw)
In-Reply-To: <1346812817.2257.23.camel@pasglop>
Hello,
On Wed, Sep 05, 2012 at 12:40:17PM +1000, Benjamin Herrenschmidt wrote:
> On Mon, 2012-07-23 at 11:13 +0200, Uwe Kleine-König wrote:
> > This prepares *of_device_id.data becoming const. Without this change
> > the following warning would occur:
> >
> > drivers/macintosh/mediabay.c: In function 'media_bay_attach':
> > drivers/macintosh/mediabay.c:589:11: warning: assignment discards 'const' qualifier from pointer target type [enabled by default]
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
>
> Ack all of these assuming you test built (I didn't).
"all" means the two mediabay patches? And yes, they are all built
tested.
> Do you need me to
> carry any of this via the powerpc tree ?
The patch that adds the const to of_device_id depends[1] on this patch.
And the other mediabay is only valid after that const is added. So the
easiest is if the series is pulled in one go. Arnd intended to let Linus
pull it for 3.6-rc1 but it was missed because of a communication
problem. So I intend to get it in during the 3.7 merge window.
Best regards
Uwe
[1] it's only a soft depend, because the result is "only" a warning, but
still.
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2012-09-05 8:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1343034810-3386-1-git-send-email-u.kleine-koenig@pengutronix.de>
2012-07-23 9:13 ` [PATCH 08/25] gpio/mpc8xxx: add a const qualifier Uwe Kleine-König
2012-07-29 16:13 ` Linus Walleij
2012-07-23 9:13 ` [PATCH 10/25] i2c/mpc: " Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 13/25] macintosh/mediabay: " Uwe Kleine-König
2012-09-05 2:40 ` Benjamin Herrenschmidt
2012-09-05 8:02 ` Uwe Kleine-König [this message]
2012-09-05 9:23 ` Benjamin Herrenschmidt
2012-09-11 6:56 ` Uwe Kleine-König
2012-09-11 7:08 ` Benjamin Herrenschmidt
2012-07-23 9:13 ` [PATCH 14/25] powerpc/83xx: " Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 15/25] powerpc/fsl_msi: " Uwe Kleine-König
2012-10-15 16:14 ` Tabi Timur-B04825
2012-07-23 9:13 ` [PATCH 16/25] powerpc/celleb_pci: " Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 17/25] watchdog/mpc8xxx: " Uwe Kleine-König
2012-07-23 10:37 ` Wim Van Sebroeck
2012-07-23 9:13 ` [PATCH 21/25] powerpc/fsl_msi: drop unneeded cast to non-const pointer Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 23/25] i2c/mpc: make data used as *of_device_id.data const Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 24/25] macintosh/mediabay: " Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905080249.GI28643@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).