From: Fengguang Wu <fengguang.wu@intel.com>
To: Gavin Shan <shangw@linux.vnet.ibm.com>
Cc: kernel-janitors@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [powerpc:next 60/78] arch/powerpc/platforms/pseries/eeh_pe.c:217:23: error: 'eeh_pe_get' defined but not used
Date: Mon, 10 Sep 2012 10:56:44 +0800 [thread overview]
Message-ID: <20120910025644.GA30229@localhost> (raw)
In-Reply-To: <20120910025121.GB1572@shangw.(null)>
On Mon, Sep 10, 2012 at 10:51:22AM +0800, Gavin Shan wrote:
> Hi Fengguang,
>
> >Hi Gavin,
> >
> >FYI, kernel build failed on
> >
> >tree: git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git next
> >head: 4715fed600109e0bd3d6cfa2b925a643173a08b4
> >commit: 22f4ab123f10e1862579785c73d9e60fa24afd4f [60/78] powerpc/eeh: Search PE based on requirement
> >config: powerpc-defconfig (attached as .config)
> >
> >All related error/warning messages:
> >
> >arch/powerpc/platforms/pseries/eeh_pe.c:217:23: error: 'eeh_pe_get' defined but not used [-Werror=unused-function]
> >arch/powerpc/platforms/pseries/eeh_pe.c:237:23: error: 'eeh_pe_get_parent' defined but not used [-Werror=unused-function]
> >cc1: all warnings being treated as errors
> >
>
> The global functions eeh_pe_get() and eeh_pe_get_parent() will be used
> by subsequent patches. I think ppc/next merged 23 patches for EEH core
> this time. I'm not sure I should refactor those patches to avoid the
> build failure? :-)
I guess it's not your fault.. I have rules to filter out
"unused-function" warnings, however in your case all warnings are
turned into errors.. Although I can filter such errors too, they will
still present as bisect holes.
Thanks,
Fengguang
next prev parent reply other threads:[~2012-09-10 2:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 2:34 [powerpc:next 60/78] arch/powerpc/platforms/pseries/eeh_pe.c:217:23: error: 'eeh_pe_get' defined but not used Fengguang Wu
2012-09-10 2:51 ` Gavin Shan
2012-09-10 2:56 ` Fengguang Wu [this message]
2012-09-10 5:18 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120910025644.GA30229@localhost \
--to=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=shangw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).