From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Eric Millbrandt <emillbrandt@dekaresearch.com>
Cc: alsa-devel@alsa-project.org, Anatolij Gustschin <agust@denx.de>,
linuxppc-dev@lists.ozlabs.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 4/5] arch/powerpc/boot/dts pcm030 add mpc5200-soc-audio node
Date: Wed, 12 Sep 2012 11:17:20 +0800 [thread overview]
Message-ID: <20120912031719.GH9162@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1347416089-23393-5-git-send-email-emillbrandt@dekaresearch.com>
On Tue, Sep 11, 2012 at 10:14:48PM -0400, Eric Millbrandt wrote:
> + analog@0 {
> + stream-name = "AC97 Analog";
> + codec-name = "wm9712-codec.0";
This name is fairly clearly an internal implementation detail of how
Linux does audio drivers, we shouldn't be using it in device tree
bindings. We should instead be doing something like referencing a
device tree node for the CODEC. Look at how drivers like the nVidia
Tegra ones handle this, though for AC'97 we should really be able to
figure out a standard hookup like this automatically at runtime, it's
all enumerable.
next prev parent reply other threads:[~2012-09-12 3:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 2:14 [RFC PATCH 0/5] mpc5200 asoc fixups Eric Millbrandt
2012-09-12 2:14 ` [PATCH 1/5] ASoC: fsl: mpc5200 multi-codec fixups Eric Millbrandt
2012-09-12 3:04 ` Mark Brown
2012-09-12 14:29 ` Eric Millbrandt
2012-09-12 2:14 ` [PATCH 2/5] ASoC: fsl: mpc5200 combine psc_dma platform data Eric Millbrandt
2012-09-12 13:54 ` Mark Brown
2012-09-12 17:15 ` [alsa-devel] " Eric Millbrandt
2012-09-12 2:14 ` [PATCH 3/5] ASoC: fsl: mpc5200-soc-audio driver Eric Millbrandt
2012-09-12 2:33 ` [alsa-devel] " Stephen Warren
2012-09-12 3:11 ` Mark Brown
2012-09-12 2:14 ` [PATCH 4/5] arch/powerpc/boot/dts pcm030 add mpc5200-soc-audio node Eric Millbrandt
2012-09-12 2:41 ` [alsa-devel] " Stephen Warren
2012-09-12 3:17 ` Mark Brown [this message]
2012-09-12 2:14 ` [PATCH 5/5] ASoC: fsl: mpc5200 remove pcm030 and efika audio fabric Eric Millbrandt
2012-09-12 3:20 ` Mark Brown
2012-09-12 14:05 ` Eric Millbrandt
2012-09-13 4:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912031719.GH9162@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=agust@denx.de \
--cc=alsa-devel@alsa-project.org \
--cc=emillbrandt@dekaresearch.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).