From: Shaun Ruffell <sruffell@digium.com>
To: Shaohui Xie <Shaohui.Xie@freescale.com>
Cc: avorontsov@mvista.com, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
linux-edac@vger.kernel.org
Subject: Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe
Date: Fri, 14 Sep 2012 13:21:37 -0500 [thread overview]
Message-ID: <20120914182137.GD18672@digium.com> (raw)
In-Reply-To: <1347533729-5893-1-git-send-email-Shaohui.Xie@freescale.com>
On Thu, Sep 13, 2012 at 06:55:29PM +0800, Shaohui Xie wrote:
> Error handle in case of DDR ECC off is wrong, sysfs entries have not been
> created, so edac_mc_free which frees a mci instance should not be called.
> Also, free mci's memory in this case.
Jus FYI: I ran into the same error in edac_mc_free() which I
resolved in a slightly different way in some patches I sent
previously. [1]
[1] https://lkml.org/lkml/2012/9/14/475
Cheers,
Shaun
next prev parent reply other threads:[~2012-09-14 18:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 10:55 [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe Shaohui Xie
2012-09-14 0:04 ` Kim Phillips
2012-09-14 18:21 ` Shaun Ruffell [this message]
2012-09-17 10:32 ` Xie Shaohui-B21989
2012-09-19 3:04 ` Shaun Ruffell
2012-09-19 3:43 ` Xie Shaohui-B21989
2012-09-19 3:53 ` Shaun Ruffell
2012-09-19 4:51 ` Xie Shaohui-B21989
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120914182137.GD18672@digium.com \
--to=sruffell@digium.com \
--cc=Shaohui.Xie@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@mvista.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).