From: Anton Blanchard <anton@samba.org>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Remove tlb batching hack for nighthawk
Date: Mon, 24 Sep 2012 07:04:05 +1000 [thread overview]
Message-ID: <20120924070405.1a5d1c33@kryten> (raw)
In-Reply-To: <1348214908-32605-1-git-send-email-michael@ellerman.id.au>
On Fri, 21 Sep 2012 18:08:28 +1000
Michael Ellerman <michael@ellerman.id.au> wrote:
> In hpte_init_native() we call tlb_batching_enabled() to decide if we
> should setup ppc_md.flush_hash_range.
>
> tlb_batching_enabled() checks the _unflattened_ device tree, to see
> if we are running on a nighthawk.
>
> Since commit a223535 ("dont allow pSeries_probe to succeed without
> initialising MMU", Dec 2006), hpte_init_native() has been called from
> pSeries_probe() - at which point we have not yet unflattened the
> device tree.
>
> This means tlb_batching_enabled() will always return true, so the hack
> has effectively been disabled since Dec 2006. Ergo, I think we can
> drop it.
Ouch. We probably had the last nighthawk in existence and we crushed it
years ago. So:
Acked-by: Anton Blanchard <anton@samba.org>
Anton
prev parent reply other threads:[~2012-09-23 21:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 8:08 [PATCH] powerpc: Remove tlb batching hack for nighthawk Michael Ellerman
2012-09-23 21:04 ` Anton Blanchard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120924070405.1a5d1c33@kryten \
--to=anton@samba.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).