From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <proski@gnu.org>
Date: Fri, 19 Oct 2012 11:55:17 -0400
From: Pavel Roskin <proski@gnu.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [ath9k-devel] [PATCH net-next 00/21] treewide: Use consistent
 api style for address testing
Message-ID: <20121019115517.7b8514a8@mj>
In-Reply-To: <1350630254.2293.183.camel@edumazet-glaptop>
References: <cover.1350618006.git.joe@perches.com>
 <1350630254.2293.183.camel@edumazet-glaptop>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Cc: linux-mips@linux-mips.org, b.a.t.m.a.n@lists.open-mesh.org,
 linux-doc@vger.kernel.org, brcm80211-dev-list@broadcom.com,
 users@rt2x00.serialmonkey.com, linux-sctp@vger.kernel.org, devel@open-fcoe.org,
 dev@openvswitch.org, linux-s390@vger.kernel.org, wimax@linuxwimax.org,
 linux-scsi@vger.kernel.org, linux-rdma@vger.kernel.org,
 bridge@lists.linux-foundation.org, lvs-devel@vger.kernel.org,
 coreteam@netfilter.org, b43-dev@lists.infradead.org,
 cbe-oss-dev@lists.ozlabs.org, devel@driverdev.osuosl.org,
 user-mode-linux-devel@lists.sourceforge.net,
 devicetree-discuss@lists.ozlabs.org,
 davinci-linux-open-source@linux.davincidsp.com, netfilter@vger.kernel.org,
 user-mode-linux-user@lists.sourceforge.net,
 linux-arm-kernel@lists.infradead.org, linux-nfs@vger.kernel.org,
 linux-parisc@vger.kernel.org, netdev@vger.kernel.org,
 linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
 linux-kernel@vger.kernel.org, e1000-devel@lists.sourceforge.net,
 ath9k-devel@lists.ath9k.org, netfilter-devel@vger.kernel.org,
 Joe Perches <joe@perches.com>, uclinux-dist-devel@blackfin.uclinux.org,
 linuxppc-dev@lists.ozlabs.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev/>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>

On Fri, 19 Oct 2012 09:04:14 +0200
Eric Dumazet <eric.dumazet@gmail.com> wrote:

> Yes they are some names discrepancies, thats a big deal.
> 
> And we have alloc_skb() / kfree_skb() / skb_clone() 
> 
> Why not skb_alloc() / skb_free() / skb_clone() ?
> 
> Some people actually know current code by name of functions, they dont
> want to change their mind and having to grep include files and git log
> to learn the new names of an old function, especially when traveling
> and using a laptop.

I agree.

Also, it makes sense to introduce a more consistent name for a function
when it's improved in some way and the callers need to be adjusted or
re-checked.

That way, the old name can be phased out as the code is made compatible
with the new function.

-- 
Regards,
Pavel Roskin