From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jean Delvare <khali@linux-fr.org>
Cc: Rudolf Marek <r.marek@assembler.cz>,
Tony Lindgren <tony@atomide.com>,
gregkh@linuxfoundation.org, Guan Xuetao <gxt@mprc.pku.edu.cn>,
Wolfram Sang <w.sang@pengutronix.de>,
"Mark M. Hoffman" <mhoffman@lightlink.com>,
Bill Pemberton <wfp5p@virginia.edu>,
linux-i2c@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>,
Barry Song <baohua.song@csr.com>, Olof Johansson <olof@lixom.net>,
linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 207/493] i2c: remove use of __devinit
Date: Tue, 20 Nov 2012 13:23:42 +0000 [thread overview]
Message-ID: <20121120132342.GP3332@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20121120092046.24496415@endymion.delvare>
On Tue, Nov 20, 2012 at 09:20:46AM +0100, Jean Delvare wrote:
> Hi Bill,
>
> On Mon, 19 Nov 2012 13:22:36 -0500, Bill Pemberton wrote:
> > CONFIG_HOTPLUG is going away as an option so __devinit is no longer
> > needed.
>
> Can you please point me/us to the discussion explaining the rationale
> behind this move, and the explanation of what will be done exactly?
> While I can easily understand that we want to drop CONFIG_HOTPLUG and
> always enable hot-plug support, I don't see where we are going with
> removing __devinit annotations and the like.
It's actually very simple to understand.
1. CONFIG_HOTPLUG is going away; it's already defined to always be 'Y'.
2. This means that the the devinit sections will not be discarded anymore.
3. As a result, there's no point the devinit sections existing anymore.
4. As there's no devinit sections, the __devinit marker is entirely
redundant and useless.
The reason this is being done is because the benefit to cost ratio of this
is far too high; it's well proven that people constantly get these markings
wrong, and with most kernels having had hotplug enabled anyway, it's not
providing much in the way of space saving benefit over the number of section
conflicts it causes. So, it's been decided a few years ago that this is
going to happen, with that justification, and it's been accepted by 300
odd kernel developers in at least one kernel summit when it was talked
about... and it's been mentioned on mailing lists several times.
next prev parent reply other threads:[~2012-11-20 13:52 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1353349642-3677-1-git-send-email-wfp5p@virginia.edu>
2012-11-19 18:19 ` [PATCH 014/493] PCI: remove CONFIG_HOTPLUG ifdefs Bill Pemberton
2012-11-19 18:19 ` [PATCH 024/493] powerpc: " Bill Pemberton
2012-11-19 18:19 ` [PATCH 035/493] powerpc: remove use of __devexit_p Bill Pemberton
2012-11-19 18:20 ` [PATCH 056/493] edac: " Bill Pemberton
2012-11-22 13:44 ` Borislav Petkov
2012-11-22 18:22 ` Greg KH
2012-11-23 10:06 ` Borislav Petkov
2012-11-23 16:40 ` Greg KH
2012-11-24 9:14 ` Borislav Petkov
2012-11-24 17:59 ` Greg KH
2012-11-19 18:20 ` [PATCH 065/493] i2c: " Bill Pemberton
2012-11-20 6:59 ` Shubhrajyoti Datta
2012-11-20 13:46 ` Jean Delvare
2012-11-22 21:49 ` Wolfram Sang
2012-11-26 13:52 ` Bill Pemberton
2012-11-19 18:20 ` [PATCH 072/493] drivers/macintosh: " Bill Pemberton
2012-11-19 18:21 ` [PATCH 117/493] tty: " Bill Pemberton
2012-11-19 18:21 ` [PATCH 119/493] usb: " Bill Pemberton
2012-11-19 20:14 ` Felipe Balbi
2012-11-20 9:29 ` Nicolas Ferre
2012-11-20 14:02 ` Peter Korsgaard
2012-11-19 18:21 ` [PATCH 146/493] ASoC: " Bill Pemberton
[not found] ` <s5hehjordzj.wl%tiwai@suse.de>
2012-11-20 6:30 ` Forward: " Mark Brown
2012-11-19 18:21 ` [PATCH 158/493] video: remove use of __devinit Bill Pemberton
2012-11-20 16:57 ` David Brown
2012-11-19 18:21 ` [PATCH 159/493] usb: " Bill Pemberton
2012-11-19 20:15 ` Felipe Balbi
2012-11-20 9:33 ` Nicolas Ferre
2012-11-20 21:44 ` Alan Stern
2012-11-19 18:21 ` [PATCH 161/493] tty: " Bill Pemberton
2012-11-20 9:34 ` Nicolas Ferre
2012-11-20 9:44 ` Tobias Klauser
2012-11-19 18:22 ` [PATCH 192/493] scsi: " Bill Pemberton
2012-11-21 11:51 ` Russell King - ARM Linux
2012-11-21 12:13 ` Guennadi Liakhovetski
2012-11-26 17:37 ` [Pv-drivers] " Dmitry Torokhov
2012-11-27 11:32 ` vinayak holikatti
2012-11-19 18:22 ` [PATCH 198/493] ethernet: " Bill Pemberton
2012-11-21 11:55 ` Russell King - ARM Linux
2012-11-19 18:22 ` [PATCH 207/493] i2c: " Bill Pemberton
2012-11-20 8:20 ` Jean Delvare
2012-11-20 13:23 ` Russell King - ARM Linux [this message]
2012-11-20 13:37 ` Jean Delvare
2012-11-21 11:02 ` Barry Song
2012-11-19 18:22 ` [PATCH 211/493] hwrng: " Bill Pemberton
2012-11-19 18:22 ` [PATCH 215/493] drivers/macintosh: " Bill Pemberton
2012-11-19 18:22 ` [PATCH 222/493] char: " Bill Pemberton
2012-11-19 18:22 ` [PATCH 226/493] dma: " Bill Pemberton
2012-11-20 3:07 ` viresh kumar
2012-11-19 18:22 ` [PATCH 227/493] edac: " Bill Pemberton
2012-11-19 18:23 ` [PATCH 238/493] mtd: " Bill Pemberton
2012-11-21 11:58 ` Russell King - ARM Linux
2012-11-19 18:23 ` [PATCH 244/493] ps3: " Bill Pemberton
2012-11-19 18:23 ` [PATCH 247/493] drivers/block: " Bill Pemberton
2012-11-19 18:23 ` [PATCH 261/493] sound: " Bill Pemberton
2012-11-19 18:23 ` [PATCH 283/493] powerpc: " Bill Pemberton
2012-11-19 18:24 ` [PATCH 295/493] tty: remove use of __devinitdata Bill Pemberton
2012-11-19 18:24 ` [PATCH 298/493] video: " Bill Pemberton
2012-11-21 12:00 ` Russell King - ARM Linux
2012-11-19 18:24 ` [PATCH 323/493] tty: " Bill Pemberton
2012-11-19 18:24 ` [PATCH 344/493] powerpc: " Bill Pemberton
2012-11-19 18:25 ` [PATCH 371/493] usb: remove use of __devinitconst Bill Pemberton
2012-11-19 20:16 ` Felipe Balbi
2012-11-19 18:25 ` [PATCH 373/493] drivers/macintosh: " Bill Pemberton
2012-11-19 18:25 ` [PATCH 382/493] powerpc: " Bill Pemberton
2012-11-19 18:25 ` [PATCH 399/493] edac: remove use of __devexit Bill Pemberton
2012-11-19 18:25 ` [PATCH 404/493] i2c: " Bill Pemberton
2012-11-19 18:26 ` [PATCH 415/493] mtd: " Bill Pemberton
2012-11-19 18:26 ` [PATCH 429/493] tty: " Bill Pemberton
2012-11-20 9:45 ` Tobias Klauser
2012-11-20 17:06 ` David Brown
2012-11-19 18:26 ` [PATCH 431/493] usb: " Bill Pemberton
2012-11-19 20:17 ` Felipe Balbi
2012-11-19 18:26 ` [PATCH 437/493] char: " Bill Pemberton
2012-11-26 20:36 ` Kent Yoder
2012-11-19 18:26 ` [PATCH 443/493] drivers/macintosh: " Bill Pemberton
2012-11-19 18:27 ` [PATCH 486/493] powerpc: " Bill Pemberton
2012-11-19 18:27 ` [PATCH 491/493] sound: " Bill Pemberton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120132342.GP3332@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=baohua.song@csr.com \
--cc=ben-linux@fluff.org \
--cc=gregkh@linuxfoundation.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=khali@linux-fr.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhoffman@lightlink.com \
--cc=olof@lixom.net \
--cc=r.marek@assembler.cz \
--cc=tony@atomide.com \
--cc=w.sang@pengutronix.de \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).