* [PATCH -next] powerpc/85xx: use for_each_compatible_node() macro
@ 2012-12-03 13:36 Wei Yongjun
2012-12-05 23:51 ` Grant Likely
2013-02-12 20:02 ` Kumar Gala
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2012-12-03 13:36 UTC (permalink / raw)
To: galak, benh, paulus, grant.likely, rob.herring
Cc: yongjun_wei, linuxppc-dev, devicetree-discuss, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Use for_each_compatible_node() macro instead of open coding it.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
arch/powerpc/platforms/85xx/mpc85xx_mds.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/85xx/mpc85xx_mds.c b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
index bd12588..a7b3621 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_mds.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
@@ -206,9 +206,7 @@ static void __init mpc85xx_mds_reset_ucc_phys(void)
setbits8(&bcsr_regs[7], BCSR7_UCC12_GETHnRST);
clrbits8(&bcsr_regs[8], BCSR8_UEM_MARVELL_RST);
- for (np = NULL; (np = of_find_compatible_node(np,
- "network",
- "ucc_geth")) != NULL;) {
+ for_each_compatible_node(np, "network", "ucc_geth") {
const unsigned int *prop;
int ucc_num;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] powerpc/85xx: use for_each_compatible_node() macro
2012-12-03 13:36 [PATCH -next] powerpc/85xx: use for_each_compatible_node() macro Wei Yongjun
@ 2012-12-05 23:51 ` Grant Likely
2013-02-12 20:02 ` Kumar Gala
1 sibling, 0 replies; 3+ messages in thread
From: Grant Likely @ 2012-12-05 23:51 UTC (permalink / raw)
To: Wei Yongjun, galak, benh, paulus, rob.herring
Cc: yongjun_wei, linuxppc-dev, devicetree-discuss, linux-kernel
On Mon, 3 Dec 2012 08:36:03 -0500, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Use for_each_compatible_node() macro instead of open coding it.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/platforms/85xx/mpc85xx_mds.c b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
> index bd12588..a7b3621 100644
> --- a/arch/powerpc/platforms/85xx/mpc85xx_mds.c
> +++ b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
> @@ -206,9 +206,7 @@ static void __init mpc85xx_mds_reset_ucc_phys(void)
> setbits8(&bcsr_regs[7], BCSR7_UCC12_GETHnRST);
> clrbits8(&bcsr_regs[8], BCSR8_UEM_MARVELL_RST);
>
> - for (np = NULL; (np = of_find_compatible_node(np,
> - "network",
> - "ucc_geth")) != NULL;) {
> + for_each_compatible_node(np, "network", "ucc_geth") {
> const unsigned int *prop;
> int ucc_num;
>
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] powerpc/85xx: use for_each_compatible_node() macro
2012-12-03 13:36 [PATCH -next] powerpc/85xx: use for_each_compatible_node() macro Wei Yongjun
2012-12-05 23:51 ` Grant Likely
@ 2013-02-12 20:02 ` Kumar Gala
1 sibling, 0 replies; 3+ messages in thread
From: Kumar Gala @ 2013-02-12 20:02 UTC (permalink / raw)
To: Wei Yongjun
Cc: devicetree-discuss, linux-kernel, rob.herring, yongjun_wei,
paulus, linuxppc-dev
On Dec 3, 2012, at 7:36 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Use for_each_compatible_node() macro instead of open coding it.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
applied to next
- k
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-12 20:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-03 13:36 [PATCH -next] powerpc/85xx: use for_each_compatible_node() macro Wei Yongjun
2012-12-05 23:51 ` Grant Likely
2013-02-12 20:02 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).