From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tx2outboundpool.messaging.microsoft.com (tx2ehsobe004.messaging.microsoft.com [65.55.88.14]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "Microsoft Secure Server Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 04AEA2C0086 for ; Tue, 15 Jan 2013 00:00:39 +1100 (EST) Date: Mon, 14 Jan 2013 20:58:56 +0800 From: Peter Chen To: Felipe Balbi Subject: Re: [PATCH v3 2/3] usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap Message-ID: <20130114125855.GB30157@nchen-desktop> References: <1358158361-25550-1-git-send-email-peter.chen@freescale.com> <1358158361-25550-3-git-send-email-peter.chen@freescale.com> <20130114101708.GC10874@arwen.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20130114101708.GC10874@arwen.pp.htv.fi> Cc: r58472@freescale.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, kernel@pengutronix.de, shawn.guo@linaro.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Jan 14, 2013 at 12:17:08PM +0200, Felipe Balbi wrote: > On Mon, Jan 14, 2013 at 06:12:40PM +0800, Peter Chen wrote: > > As mach/hardware.h is deleted, we can't visit platform code at driver. > > It has no phy driver to combine with this controller, so it has to use > > ioremap to map phy address as a workaround. > > > > Signed-off-by: Peter Chen > > --- > > drivers/usb/gadget/fsl_mxc_udc.c | 12 +++++++----- > > 1 files changed, 7 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/usb/gadget/fsl_mxc_udc.c b/drivers/usb/gadget/fsl_mxc_udc.c > > index 6df45f7..0e858e6 100644 > > --- a/drivers/usb/gadget/fsl_mxc_udc.c > > +++ b/drivers/usb/gadget/fsl_mxc_udc.c > > @@ -23,7 +23,8 @@ static struct clk *mxc_per_clk; > > static struct clk *mxc_ipg_clk; > > > > /* workaround ENGcm09152 for i.MX35 */ > > -#define USBPHYCTRL_OTGBASE_OFFSET 0x608 > > +#define MX35_USBPHYCTRL_OFFSET 0x600 > > +#define USBPHYCTRL_OTGBASE_OFFSET 0x8 > > #define USBPHYCTRL_EVDO (1 << 23) > > > > int fsl_udc_clk_init(enum fsl_udc_type devtype, struct platform_device *pdev) > > @@ -83,15 +84,16 @@ void fsl_udc_clk_finalize(enum fsl_udc_type devtype, > > struct fsl_usb2_platform_data *pdata = pdev->dev.platform_data; > > if (devtype == IMX35_UDC) { > > unsigned int v; > > + void __iomem *phy_regs = ioremap((unsigned long)pdata->regs + > > + MX35_USBPHYCTRL_OFFSET, 512); > > as I said before, this should be passed via struct resource, not pdata. My careless, will change at next version > > -- > balbi -- Best Regards, Peter Chen