From: "Lennart Sorensen" <lsorense@csclub.uwaterloo.ca>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: ethtool occationally fails to communicate with with ucc_geth
Date: Wed, 6 Feb 2013 17:24:38 -0500 [thread overview]
Message-ID: <20130206222438.GK30788@csclub.uwaterloo.ca> (raw)
In-Reply-To: <1360184912.2659.27.camel@bwh-desktop.uk.solarflarecom.com>
On Wed, Feb 06, 2013 at 09:08:32PM +0000, Ben Hutchings wrote:
> This seems to be a workaround for a bug in phylib: phy_state_machine()
> calls netif_carrier_on() before adjust_link(), so the TX scheduler can
> start immediately even though the MAC has not been configured.
>
> A better workaround would be to use netif_carrier_{off,on}() in
> ugeth_{quiesce,activate}() respectively instead of
> netif_device_{detach,attach}(). But I think phylib really ought to be
> fixed.
I am willing to try things, but this is certainly in parts of the network
stack I don't normally poke around in and hence don't know how works.
I just managed to track it down this far. :)
I can try the carrier_off/on in place of the detach/attach and see if
it works.
--
Len Sorensen
prev parent reply other threads:[~2013-02-06 22:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 20:05 ethtool occationally fails to communicate with with ucc_geth Lennart Sorensen
2013-02-06 21:08 ` Ben Hutchings
2013-02-06 22:24 ` Lennart Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130206222438.GK30788@csclub.uwaterloo.ca \
--to=lsorense@csclub.uwaterloo.ca \
--cc=bhutchings@solarflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox