From: Michael Ellerman <michael@ellerman.id.au>
To: Phileas Fogg <phileas-fogg@mail.ru>
Cc: linuxppc-dev@lists.ozlabs.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: PS3 platform is broken on Linux 3.7.0
Date: Mon, 11 Feb 2013 14:39:08 +1100 [thread overview]
Message-ID: <20130211033908.GA21369@concordia> (raw)
In-Reply-To: <1360518697.255951128@f337.mail.ru>
On Sun, Feb 10, 2013 at 09:51:37PM +0400, Phileas Fogg wrote:
>
> >Phileas Fogg < phileas-fogg@mail.ru > writes:
> >
>
> Patch:
>
> --- arch/powerpc/kernel/setup_64.c.old 2013-02-10 19:34:53.787366191 +0100
> +++ arch/powerpc/kernel/setup_64.c 2013-02-10 19:35:38.834035478 +0100
> @@ -186,6 +186,9 @@
> initialise_paca(&boot_paca, 0);
> setup_paca(&boot_paca);
>
> + /* Allow percpu accesses to "work" until we setup percpu data */
> + boot_paca.data_offset = 0;
> +
This is correct.
> /* Initialize lockdep early or else spinlocks will blow */
> lockdep_init();
>
> @@ -208,8 +211,6 @@
>
> /* Fix up paca fields required for the boot cpu */
> get_paca()->cpu_start = 1;
> - /* Allow percpu accesses to "work" until we setup percpu data */
> - get_paca()->data_offset = 0;
But this is not.
As you said, they are different pacas, so we need to make sure both
boot_paca, and "the paca of the boot cpu" are initialised with
data_offset = 0.
I'll send a patch to sort it.
cheers
next prev parent reply other threads:[~2013-02-11 3:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 12:35 PS3 platform is broken on Linux 3.7.0 Phileas Fogg
2012-12-19 21:53 ` Benjamin Herrenschmidt
2013-01-12 2:12 ` Geoff Levand
2013-01-14 23:37 ` Geoff Levand
2013-02-10 8:59 ` Re[2]: " Phileas Fogg
2013-02-10 9:16 ` Re[3]: " Phileas Fogg
2013-02-10 16:11 ` Aneesh Kumar K.V
2013-02-11 10:26 ` Aneesh Kumar K.V
2013-02-11 16:57 ` Re[5]: " Phileas Fogg
2013-02-12 1:11 ` Re[3]: " Geoff Levand
2013-02-11 20:56 ` Re[2]: " Geoff Levand
2013-02-10 11:45 ` Phileas Fogg
2013-02-10 12:17 ` Re[3]: " Phileas Fogg
2013-02-10 15:46 ` Aneesh Kumar K.V
2013-02-10 17:51 ` Re[5]: " Phileas Fogg
2013-02-11 3:39 ` Michael Ellerman [this message]
2013-02-13 7:32 ` Geoff Levand
2013-02-13 22:37 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211033908.GA21369@concordia \
--to=michael@ellerman.id.au \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=phileas-fogg@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).