* [PATCH] ppc32: Fix compile of sha1-powerpc-asm.S
@ 2013-02-26 2:20 Tony Breeds
2013-03-05 1:23 ` Christian Kujau
0 siblings, 1 reply; 4+ messages in thread
From: Tony Breeds @ 2013-02-26 2:20 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Josh Boyer, LinuxPPC-dev
When building with CRYPTO_SHA1_PPC enabled we fail with:
---
powerpc/crypto/sha1-powerpc-asm.S: Assembler messages:
powerpc/crypto/sha1-powerpc-asm.S:116: Error: can't resolve `0' {*ABS* section} - `STACKFRAMESIZE' {*UND* section}
powerpc/crypto/sha1-powerpc-asm.S:116: Error: expression too complex
powerpc/crypto/sha1-powerpc-asm.S:178: Error: unsupported relocation against STACKFRAMESIZE
---
Use INT_FRAME_SIZE instead.
Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
---
arch/powerpc/crypto/sha1-powerpc-asm.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
FWIW the SHA1_PPC makes about a 20% difference on my 32bit board
diff --git a/arch/powerpc/crypto/sha1-powerpc-asm.S b/arch/powerpc/crypto/sha1-powerpc-asm.S
index a5f8264..125e165 100644
--- a/arch/powerpc/crypto/sha1-powerpc-asm.S
+++ b/arch/powerpc/crypto/sha1-powerpc-asm.S
@@ -113,7 +113,7 @@
STEPUP4((t)+16, fn)
_GLOBAL(powerpc_sha_transform)
- PPC_STLU r1,-STACKFRAMESIZE(r1)
+ PPC_STLU r1,-INT_FRAME_SIZE(r1)
SAVE_8GPRS(14, r1)
SAVE_10GPRS(22, r1)
@@ -175,5 +175,5 @@ _GLOBAL(powerpc_sha_transform)
REST_8GPRS(14, r1)
REST_10GPRS(22, r1)
- addi r1,r1,STACKFRAMESIZE
+ addi r1,r1,INT_FRAME_SIZE
blr
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ppc32: Fix compile of sha1-powerpc-asm.S
2013-02-26 2:20 [PATCH] ppc32: Fix compile of sha1-powerpc-asm.S Tony Breeds
@ 2013-03-05 1:23 ` Christian Kujau
2013-03-06 4:09 ` Michael Ellerman
0 siblings, 1 reply; 4+ messages in thread
From: Christian Kujau @ 2013-03-05 1:23 UTC (permalink / raw)
To: Tony Breeds; +Cc: LinuxPPC-dev
On Tue, 26 Feb 2013 at 13:20, Tony Breeds wrote:
> When building with CRYPTO_SHA1_PPC enabled we fail with:
> ---
> powerpc/crypto/sha1-powerpc-asm.S: Assembler messages:
> powerpc/crypto/sha1-powerpc-asm.S:116: Error: can't resolve `0' {*ABS* section} - `STACKFRAMESIZE' {*UND* section}
> powerpc/crypto/sha1-powerpc-asm.S:116: Error: expression too complex
> powerpc/crypto/sha1-powerpc-asm.S:178: Error: unsupported relocation against STACKFRAMESIZE
> ---
>
> Use INT_FRAME_SIZE instead.
>
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
Thanks for the fix! Ran into this as well, with your patch 3.9-rc1
compiles again (and it even boots :-))
Tested-by: Christian Kujau <lists@nerdbynature.de>
$ grep -A10 sha1 /proc/crypto
name : sha1
driver : sha1-powerpc
module : kernel
priority : 0
refcnt : 1
selftest : passed
type : shash
blocksize : 64
digestsize : 20
> ---
> arch/powerpc/crypto/sha1-powerpc-asm.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> FWIW the SHA1_PPC makes about a 20% difference on my 32bit board
>
> diff --git a/arch/powerpc/crypto/sha1-powerpc-asm.S b/arch/powerpc/crypto/sha1-powerpc-asm.S
> index a5f8264..125e165 100644
> --- a/arch/powerpc/crypto/sha1-powerpc-asm.S
> +++ b/arch/powerpc/crypto/sha1-powerpc-asm.S
> @@ -113,7 +113,7 @@
> STEPUP4((t)+16, fn)
>
> _GLOBAL(powerpc_sha_transform)
> - PPC_STLU r1,-STACKFRAMESIZE(r1)
> + PPC_STLU r1,-INT_FRAME_SIZE(r1)
> SAVE_8GPRS(14, r1)
> SAVE_10GPRS(22, r1)
>
> @@ -175,5 +175,5 @@ _GLOBAL(powerpc_sha_transform)
>
> REST_8GPRS(14, r1)
> REST_10GPRS(22, r1)
> - addi r1,r1,STACKFRAMESIZE
> + addi r1,r1,INT_FRAME_SIZE
> blr
> --
> 1.8.1.2
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
--
BOFH excuse #21:
POSIX compliance problem
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ppc32: Fix compile of sha1-powerpc-asm.S
2013-03-05 1:23 ` Christian Kujau
@ 2013-03-06 4:09 ` Michael Ellerman
2013-03-06 6:42 ` Christian Kujau
0 siblings, 1 reply; 4+ messages in thread
From: Michael Ellerman @ 2013-03-06 4:09 UTC (permalink / raw)
To: Christian Kujau; +Cc: LinuxPPC-dev
On Mon, Mar 04, 2013 at 05:23:14PM -0800, Christian Kujau wrote:
> On Tue, 26 Feb 2013 at 13:20, Tony Breeds wrote:
> > When building with CRYPTO_SHA1_PPC enabled we fail with:
> > ---
> > powerpc/crypto/sha1-powerpc-asm.S: Assembler messages:
> > powerpc/crypto/sha1-powerpc-asm.S:116: Error: can't resolve `0' {*ABS* section} - `STACKFRAMESIZE' {*UND* section}
> > powerpc/crypto/sha1-powerpc-asm.S:116: Error: expression too complex
> > powerpc/crypto/sha1-powerpc-asm.S:178: Error: unsupported relocation against STACKFRAMESIZE
> > ---
> >
> > Use INT_FRAME_SIZE instead.
> >
> > Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
>
> Thanks for the fix! Ran into this as well, with your patch 3.9-rc1
> compiles again (and it even boots :-))
>
> Tested-by: Christian Kujau <lists@nerdbynature.de>
>
> $ grep -A10 sha1 /proc/crypto
> name : sha1
> driver : sha1-powerpc
> module : kernel
> priority : 0
> refcnt : 1
> selftest : passed
> type : shash
> blocksize : 64
> digestsize : 20
Thanks Christian. What hardware are you on?
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-06 6:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-26 2:20 [PATCH] ppc32: Fix compile of sha1-powerpc-asm.S Tony Breeds
2013-03-05 1:23 ` Christian Kujau
2013-03-06 4:09 ` Michael Ellerman
2013-03-06 6:42 ` Christian Kujau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).