From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH net-next] drivers:net: Remove unnecessary OOM messages after netdev_alloc_skb
Date: Sat, 09 Mar 2013 16:11:42 -0500 (EST) [thread overview]
Message-ID: <20130309.161142.153533460204187265.davem@davemloft.net> (raw)
In-Reply-To: <6379afbec3439c45180956b06c13b02ce3c9f802.1362790535.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Fri, 8 Mar 2013 17:03:25 -0800
> Emitting netdev_alloc_skb and netdev_alloc_skb_ip_align OOM
> messages is unnecessary as there is already a dump_stack
> after allocation failures.
>
> Other trivial changes around these removals:
>
> Convert a few comparisons of pointer to 0 to !pointer.
> Change flow to remove unnecessary label.
> Remove now unused variable.
> Hoist assignment from if.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
prev parent reply other threads:[~2013-03-09 21:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 1:03 [PATCH net-next] drivers:net: Remove unnecessary OOM messages after netdev_alloc_skb Joe Perches
2013-03-09 21:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130309.161142.153533460204187265.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).