* [PATCH 1/9] powerpc,kvm: fix imbalance srcu_read_[un]lock() [not found] <1363366257-4886-1-git-send-email-laijs@cn.fujitsu.com> @ 2013-03-15 16:50 ` Lai Jiangshan 2013-03-17 21:26 ` Paul Mackerras 0 siblings, 1 reply; 3+ messages in thread From: Lai Jiangshan @ 2013-03-15 16:50 UTC (permalink / raw) To: Paul E. McKenney, Andrew Morton, linux-kernel Cc: Lai Jiangshan, Gleb Natapov, Marcelo Tosatti, Alexander Graf, kvm-ppc, Paul Mackerras, kvm, linuxppc-dev At the point of up_out label in kvmppc_hv_setup_htab_rma(), srcu read lock is still held. We have to release it before return. Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> Cc: Marcelo Tosatti <mtosatti@redhat.com> Cc: Gleb Natapov <gleb@redhat.com> Cc: Alexander Graf <agraf@suse.de> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: kvm@vger.kernel.org Cc: kvm-ppc@vger.kernel.org --- arch/powerpc/kvm/book3s_hv.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c index 80dcc53..c26740e 100644 --- a/arch/powerpc/kvm/book3s_hv.c +++ b/arch/powerpc/kvm/book3s_hv.c @@ -1799,7 +1799,7 @@ static int kvmppc_hv_setup_htab_rma(struct kvm_vcpu *vcpu) up_out: up_read(¤t->mm->mmap_sem); - goto out; + goto out_srcu; } int kvmppc_core_init_vm(struct kvm *kvm) -- 1.7.4.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/9] powerpc,kvm: fix imbalance srcu_read_[un]lock() 2013-03-15 16:50 ` [PATCH 1/9] powerpc,kvm: fix imbalance srcu_read_[un]lock() Lai Jiangshan @ 2013-03-17 21:26 ` Paul Mackerras 2013-04-11 21:51 ` Paul E. McKenney 0 siblings, 1 reply; 3+ messages in thread From: Paul Mackerras @ 2013-03-17 21:26 UTC (permalink / raw) To: Lai Jiangshan Cc: kvm, Gleb Natapov, Marcelo Tosatti, Alexander Graf, kvm-ppc, linux-kernel, Andrew Morton, Paul E. McKenney, linuxppc-dev On Sat, Mar 16, 2013 at 12:50:49AM +0800, Lai Jiangshan wrote: > At the point of up_out label in kvmppc_hv_setup_htab_rma(), > srcu read lock is still held. > > We have to release it before return. > > Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> > Cc: Marcelo Tosatti <mtosatti@redhat.com> > Cc: Gleb Natapov <gleb@redhat.com> > Cc: Alexander Graf <agraf@suse.de> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: kvm@vger.kernel.org > Cc: kvm-ppc@vger.kernel.org > --- > arch/powerpc/kvm/book3s_hv.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c > index 80dcc53..c26740e 100644 > --- a/arch/powerpc/kvm/book3s_hv.c > +++ b/arch/powerpc/kvm/book3s_hv.c > @@ -1799,7 +1799,7 @@ static int kvmppc_hv_setup_htab_rma(struct kvm_vcpu *vcpu) > > up_out: > up_read(¤t->mm->mmap_sem); > - goto out; > + goto out_srcu; Acked-by: Paul Mackerras <paulus@samba.org> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/9] powerpc,kvm: fix imbalance srcu_read_[un]lock() 2013-03-17 21:26 ` Paul Mackerras @ 2013-04-11 21:51 ` Paul E. McKenney 0 siblings, 0 replies; 3+ messages in thread From: Paul E. McKenney @ 2013-04-11 21:51 UTC (permalink / raw) To: Paul Mackerras Cc: Lai Jiangshan, Gleb Natapov, Marcelo Tosatti, Alexander Graf, kvm-ppc, linux-kernel, kvm, Andrew Morton, linuxppc-dev On Mon, Mar 18, 2013 at 08:26:48AM +1100, Paul Mackerras wrote: > On Sat, Mar 16, 2013 at 12:50:49AM +0800, Lai Jiangshan wrote: > > At the point of up_out label in kvmppc_hv_setup_htab_rma(), > > srcu read lock is still held. > > > > We have to release it before return. > > > > Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> > > Cc: Marcelo Tosatti <mtosatti@redhat.com> > > Cc: Gleb Natapov <gleb@redhat.com> > > Cc: Alexander Graf <agraf@suse.de> > > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > > Cc: Paul Mackerras <paulus@samba.org> > > Cc: kvm@vger.kernel.org > > Cc: kvm-ppc@vger.kernel.org > > --- > > arch/powerpc/kvm/book3s_hv.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c > > index 80dcc53..c26740e 100644 > > --- a/arch/powerpc/kvm/book3s_hv.c > > +++ b/arch/powerpc/kvm/book3s_hv.c > > @@ -1799,7 +1799,7 @@ static int kvmppc_hv_setup_htab_rma(struct kvm_vcpu *vcpu) > > > > up_out: > > up_read(¤t->mm->mmap_sem); > > - goto out; > > + goto out_srcu; > > Acked-by: Paul Mackerras <paulus@samba.org> Thank you both, queued for 3.11 (assuming no one has beat me to it). Thanx, Paul ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-11 21:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1363366257-4886-1-git-send-email-laijs@cn.fujitsu.com>
2013-03-15 16:50 ` [PATCH 1/9] powerpc,kvm: fix imbalance srcu_read_[un]lock() Lai Jiangshan
2013-03-17 21:26 ` Paul Mackerras
2013-04-11 21:51 ` Paul E. McKenney
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).