From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: ppcdev <linuxppc-dev@lists.ozlabs.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] powerpc/uprobes: teach uprobes to ignore gdb breakpoints
Date: Thu, 21 Mar 2013 12:47:07 +0530 [thread overview]
Message-ID: <20130321071707.GB5271@in.ibm.com> (raw)
In-Reply-To: <20130320160728.GB20352@redhat.com>
On Wed, Mar 20, 2013 at 05:07:28PM +0100, Oleg Nesterov wrote:
> On 03/20, Ananth N Mavinakayanahalli wrote:
> >
> > On Wed, Mar 20, 2013 at 01:43:01PM +0100, Oleg Nesterov wrote:
> > > On 03/20, Oleg Nesterov wrote:
> > > >
> > > > But we did not install UPROBE_SWBP_INSN. Is it fine? I hope yes, just to
> > > > verify. If not, we need 2 definitions. is_uprobe_insn() should still check
> > > > insns == UPROBE_SWBP_INSN, and is_swbp_insn() should check is_trap().
> > > >
> > > > And I am just curious, could you explain how X and UPROBE_SWBP_INSN
> > > > differ?
> > >
> > > IOW, if I wasn't clear... Lets forget about gdb/etc for the moment.
> > > Suppose we apply the patch below. Will uprobes on powerpc work?
> > >
> > > If yes, then your patch should be fine. If not, we probably need more
> > > changes.
> >
> > Yes, it will work fine.
>
> Even if this new insn is conditional?
Yes.
next prev parent reply other threads:[~2013-03-21 7:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 10:40 [PATCH] powerpc/uprobes: teach uprobes to ignore gdb breakpoints Ananth N Mavinakayanahalli
2013-03-20 12:26 ` Oleg Nesterov
2013-03-20 12:43 ` Oleg Nesterov
2013-03-20 15:42 ` Ananth N Mavinakayanahalli
2013-03-20 16:07 ` Oleg Nesterov
2013-03-21 7:17 ` Ananth N Mavinakayanahalli [this message]
2013-03-21 16:00 ` Oleg Nesterov
2013-03-22 4:37 ` Ananth N Mavinakayanahalli
2013-03-20 15:41 ` Ananth N Mavinakayanahalli
2013-03-20 16:06 ` Oleg Nesterov
2013-03-21 7:15 ` Ananth N Mavinakayanahalli
2013-03-21 15:58 ` Oleg Nesterov
2013-03-22 4:47 ` Ananth N Mavinakayanahalli
2013-03-22 14:46 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321071707.GB5271@in.ibm.com \
--to=ananth@in.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oleg@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).