From: Arnd Bergmann <arnd@arndb.de>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: robin.randhawa@arm.com, linux-pm@vger.kernel.org,
patches@linaro.org, Liviu.Dudau@arm.com,
linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org,
rjw@sisk.pl, Steve.Bannister@arm.com, arvind.chauhan@arm.com,
linuxppc-dev@lists.ozlabs.org, linaro-kernel@lists.linaro.org,
charles.garcia-tobin@arm.com
Subject: Re: [PATCH 18/18] cpufreq: powerpc/platforms/cell: move cpufreq driver to drivers/cpufreq
Date: Thu, 4 Apr 2013 13:02:09 +0000 [thread overview]
Message-ID: <201304041302.09995.arnd@arndb.de> (raw)
In-Reply-To: <0f989533f2e47d4d632710029bf0273082bafee3.1365079581.git.viresh.kumar@linaro.org>
On Thursday 04 April 2013, Viresh Kumar wrote:
> This patch moves cpufreq driver of powerpc platforms/cell to drivers/cpufreq.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Compile Tested only.
>
> arch/powerpc/platforms/cell/Kconfig | 26 +---------------------
> arch/powerpc/platforms/cell/Makefile | 3 ---
> drivers/cpufreq/Kconfig.powerpc | 18 +++++++++++++++
> drivers/cpufreq/Makefile | 3 +++
> .../cpufreq/ppc_cbe_cpufreq.c | 2 +-
> .../cpufreq/ppc_cbe_cpufreq_pervasive.c | 3 +--
> .../cpufreq/ppc_cbe_cpufreq_pmi.c | 3 +--
> .../linux/ppc_cbe_cpufreq.h | 4 ++--
Moving the files is good, but I don't see a reason to make the cbe_cpufreq.h
header globally visible in include/linux/. Isn't it just used by as the
interface between ppc_cbe_cpufreq_pmi.c and ppc_cbe_cpufreq.c?
Arnd
next prev parent reply other threads:[~2013-04-04 13:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1365079581.git.viresh.kumar@linaro.org>
2013-04-04 12:54 ` [PATCH 17/18] cpufreq: powerpc: move cpufreq driver to drivers/cpufreq Viresh Kumar
2013-04-05 6:46 ` Viresh Kumar
2013-04-09 8:35 ` Viresh Kumar
2013-04-22 6:49 ` Viresh Kumar
2013-05-13 6:04 ` Viresh Kumar
2013-05-20 4:40 ` Viresh Kumar
2013-05-31 10:50 ` Viresh Kumar
2013-06-07 5:18 ` Viresh Kumar
2013-06-07 11:58 ` Rafael J. Wysocki
2013-04-04 12:54 ` [PATCH 18/18] cpufreq: powerpc/platforms/cell: " Viresh Kumar
2013-04-04 13:02 ` Arnd Bergmann [this message]
2013-04-04 13:50 ` Viresh Kumar
2013-04-04 14:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304041302.09995.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=arvind.chauhan@arm.com \
--cc=charles.garcia-tobin@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
--cc=robin.randhawa@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).