From: David Miller <davem@davemloft.net>
To: sebastian.hesselbarth@gmail.com
Cc: andrew@lunn.ch, jason@lakedaemon.net,
linux-kernel@vger.kernel.org, w@1wt.eu, smoch@web.de,
paulus@samba.org, linux-arm-kernel@lists.infradead.org,
dale@farnsworth.org, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, florian@openwrt.org,
buytenh@wantstofly.org
Subject: Re: [PATCH] net: mv643xx_eth: Add GRO support
Date: Thu, 11 Apr 2013 13:31:19 -0400 (EDT) [thread overview]
Message-ID: <20130411.133119.913809939413807690.davem@davemloft.net> (raw)
In-Reply-To: <CABJ1b_TRxm97DKJLP_h0VwMJvcYmSpjoJvtg1KvBNGah=VzqMQ@mail.gmail.com>
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Date: Thu, 11 Apr 2013 17:27:03 +0200
> On Thu, Apr 11, 2013 at 5:03 PM, Willy Tarreau <w@1wt.eu> wrote:
>> On Thu, Apr 11, 2013 at 04:47:49PM +0200, Sebastian Hesselbarth wrote:
>>> I tried todays net-next on top of 3.9-rc6 without any gro patch, with
>>> the initial
>>> patch (Soeren) and your proposed patch (Willy). The results show that
>>> both patches
>>> allow a significant increase in throughput compared to
>>> netif_receive_skb (!gro, !lro)
>>> alone. Having gro with lro disabled gives some 2% more throughput
>>> compared to lro only.
>>
>> Indeed this is consistent with my memories, since Eric improved the
>> GRO path, it became faster than LRO on this chip.
>
> I don't have a strong opinion on whether Soeren's or your proposal should
> be submitted. But I insist on having one of them in, as GRO significantly
> improves the common use case, is enabled by default, and not as
> constrained as LRO.
I think, as per other drivers, LRO should be eliminated completely from
all drivers, including this one, and GRO used exclusively instead.
next prev parent reply other threads:[~2013-04-11 17:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 12:40 [PATCH] net: mv643xx_eth: Add GRO support Sebastian Hesselbarth
2013-04-11 13:13 ` Willy Tarreau
2013-04-11 14:47 ` Sebastian Hesselbarth
2013-04-11 15:03 ` Willy Tarreau
2013-04-11 15:27 ` Sebastian Hesselbarth
2013-04-11 15:32 ` Willy Tarreau
2013-04-11 15:54 ` Eric Dumazet
2013-04-11 16:02 ` Willy Tarreau
2013-04-11 16:10 ` Eric Dumazet
2013-04-11 16:59 ` Sebastian Hesselbarth
2013-04-11 17:13 ` Willy Tarreau
2013-04-11 17:31 ` David Miller [this message]
2013-04-11 17:35 ` Eric Dumazet
2013-04-11 17:51 ` Willy Tarreau
2013-04-11 17:59 ` Eric Dumazet
2013-04-11 18:02 ` Willy Tarreau
2013-04-11 15:54 ` Eric Dumazet
2013-04-11 17:55 ` Ben Hutchings
2013-04-11 18:07 ` Sebastian Hesselbarth
2013-04-11 20:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411.133119.913809939413807690.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=buytenh@wantstofly.org \
--cc=dale@farnsworth.org \
--cc=florian@openwrt.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=smoch@web.de \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).