From: Michael Ellerman <michael@ellerman.id.au>
To: Lucas Kannebley Tavares <lucaskt@linux.vnet.ibm.com>
Cc: David Airlie <airlied@linux.ie>,
Brian King <brking@linux.vnet.ibm.com>,
dri-devel@lists.freedesktop.org,
Kleber Sacilotto de Souza <klebers@linux.vnet.ibm.com>,
Alex Deucher <alexander.deucher@amd.com>,
Jerome Glisse <jglisse@redhat.com>,
Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCHv3 1/2] ppc64: perform proper max_bus_speed detection
Date: Mon, 15 Apr 2013 15:00:02 +1000 [thread overview]
Message-ID: <20130415050001.GA21147@concordia> (raw)
In-Reply-To: <1365685994-32603-2-git-send-email-lucaskt@linux.vnet.ibm.com>
On Thu, Apr 11, 2013 at 10:13:13AM -0300, Lucas Kannebley Tavares wrote:
> On pseries machines the detection for max_bus_speed should be done
> through an OpenFirmware property. This patch adds a function to perform this
> detection and a hook to perform dynamic adding of the function only for
> pseries.
The crucial detail you didn't mention is that pcibios_root_bridge_prepare()
already exists as a weak function in the PCI code and is called from
pci_create_root_bus().
> diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c
> index 8bcc9ca..15796b5 100644
> --- a/arch/powerpc/platforms/pseries/setup.c
> +++ b/arch/powerpc/platforms/pseries/setup.c
> @@ -430,6 +430,8 @@ static void pSeries_machine_kexec(struct kimage *image)
> }
> #endif
>
> +int pseries_root_bridge_prepare(struct pci_host_bridge *bridge);
> +
Don't do that, put it in a header where it belongs.
cheers
next prev parent reply other threads:[~2013-04-15 5:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 13:13 [PATCHv3 0/2] Speed Cap fixes for ppc64 Lucas Kannebley Tavares
2013-04-11 13:13 ` [PATCHv3 1/2] ppc64: perform proper max_bus_speed detection Lucas Kannebley Tavares
2013-04-15 5:00 ` Michael Ellerman [this message]
2013-04-17 12:38 ` Lucas Kannebley Tavares
2013-04-15 11:42 ` Michael Ellerman
2013-04-17 12:40 ` Lucas Kannebley Tavares
2013-04-11 13:13 ` [PATCHv3 2/2] radeon: use max_bus_speed to activate gen2 speeds Lucas Kannebley Tavares
2013-04-12 16:38 ` Bjorn Helgaas
2013-04-16 3:17 ` Dave Airlie
2013-04-17 12:38 ` Lucas Kannebley Tavares
2013-04-17 20:04 ` Alex Deucher
2013-04-17 20:11 ` Bjorn Helgaas
2013-04-17 20:17 ` Alex Deucher
2013-04-17 20:30 ` Bjorn Helgaas
2013-04-12 13:52 ` [PATCHv3 0/2] Speed Cap fixes for ppc64 Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130415050001.GA21147@concordia \
--to=michael@ellerman.id.au \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=bhelgaas@google.com \
--cc=brking@linux.vnet.ibm.com \
--cc=cascardo@linux.vnet.ibm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jglisse@redhat.com \
--cc=klebers@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lucaskt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).