From: Joerg Roedel <joro@8bytes.org>
To: Varun Sethi <Varun.Sethi@freescale.com>
Cc: stuart.yoder@freescale.com, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, scottwood@freescale.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/3 v2] iommu: Move swap_pci_ref function to pci.h.
Date: Tue, 23 Apr 2013 15:01:54 +0200 [thread overview]
Message-ID: <20130423125827.GD2589@8bytes.org> (raw)
In-Reply-To: <1366691726-9023-1-git-send-email-Varun.Sethi@freescale.com>
On Tue, Apr 23, 2013 at 10:05:24AM +0530, Varun Sethi wrote:
> +#ifndef __PCI_H
> +#define __PCI_H
Using __PCI_H is not a wise choice, it has certainly a high risk of a
collision. Anyway, I changed it to __IOMMU_PCI_H and applied the patch.
Joerg
next prev parent reply other threads:[~2013-04-23 13:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 4:35 [PATCH 1/3 v2] iommu: Move swap_pci_ref function to pci.h Varun Sethi
2013-04-23 4:35 ` [PATCH 2/3 v14] iommu/fsl: Add additional iommu attributes required by the PAMU driver Varun Sethi
2013-04-23 13:38 ` Joerg Roedel
2013-04-23 14:10 ` Sethi Varun-B16395
2013-04-24 10:51 ` Joerg Roedel
2013-04-24 11:21 ` Sethi Varun-B16395
2013-04-23 15:26 ` Yoder Stuart-B08248
2013-04-23 4:35 ` [PATCH 3/3 v14] iommu/fsl: Freescale PAMU driver and iommu implementation Varun Sethi
2013-04-23 13:01 ` Joerg Roedel [this message]
2013-04-23 13:02 ` [PATCH 1/3 v2] iommu: Move swap_pci_ref function to pci.h Sethi Varun-B16395
-- strict thread matches above, loose matches on Subject: below --
2013-04-22 5:31 Varun Sethi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130423125827.GD2589@8bytes.org \
--to=joro@8bytes.org \
--cc=Varun.Sethi@freescale.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
--cc=stuart.yoder@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).