From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net (unknown [IPv6:2001:4f8:3:36:211:85ff:fe63:a549]) by ozlabs.org (Postfix) with ESMTP id DF57A2C02EE for ; Tue, 28 May 2013 06:19:02 +1000 (EST) Date: Mon, 27 May 2013 13:18:57 -0700 (PDT) Message-Id: <20130527.131857.945196320286011406.davem@davemloft.net> To: benh@kernel.crashing.org Subject: Re: [PATCH 1/2] ARM: kirkwood: proper retain MAC address workaround on DT ethernet From: David Miller In-Reply-To: <1369655404.3557.33.camel@pasglop> References: <1369647565.3557.28.camel@pasglop> <51A33447.80305@gmail.com> <1369655404.3557.33.camel@pasglop> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Cc: andrew@lunn.ch, jason@lakedaemon.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, buytenh@wantstofly.org, grant.likely@linaro.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Benjamin Herrenschmidt Date: Mon, 27 May 2013 21:50:04 +1000 > It would be handy to be able to just do something like > > of_set_property(node, name, ptr, len); > > However, that wouldn't help much with the allocation/leak problem, > though at least it would be easier to use. It could also *try* to re-use > the current allocation if the new content is of smaller or equal size. And this is so much better of an interface because it allows the OF implementation to decide how to deal with memory allocation and freeing.