linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk/mpc85xx: Update the compatible string
@ 2013-05-22  8:22 Yuantian.Tang
  2013-05-30 18:57 ` Mike Turquette
  0 siblings, 1 reply; 5+ messages in thread
From: Yuantian.Tang @ 2013-05-22  8:22 UTC (permalink / raw)
  To: mturquette; +Cc: Tang Yuantian, devicetree-discuss, linuxppc-dev

From: Tang Yuantian <yuantian.tang@freescale.com>

The compatible string of clock is changed from *-2 to *-2.0
on chassis 2. So updated it accordingly.

Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
---
 drivers/clk/clk-ppc-corenet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c
index a2d483f..e958707 100644
--- a/drivers/clk/clk-ppc-corenet.c
+++ b/drivers/clk/clk-ppc-corenet.c
@@ -260,7 +260,7 @@ static int __init ppc_corenet_clk_probe(struct platform_device *pdev)
 
 static const struct of_device_id ppc_clk_ids[] __initconst = {
 	{ .compatible = "fsl,qoriq-clockgen-1.0", },
-	{ .compatible = "fsl,qoriq-clockgen-2", },
+	{ .compatible = "fsl,qoriq-clockgen-2.0", },
 	{}
 };
 
-- 
1.8.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] clk/mpc85xx: Update the compatible string
  2013-05-22  8:22 [PATCH] clk/mpc85xx: Update the compatible string Yuantian.Tang
@ 2013-05-30 18:57 ` Mike Turquette
  2013-05-30 19:21   ` Mike Turquette
  0 siblings, 1 reply; 5+ messages in thread
From: Mike Turquette @ 2013-05-30 18:57 UTC (permalink / raw)
  To: Yuantian.Tang; +Cc: Tang Yuantian, devicetree-discuss, linuxppc-dev

Quoting Yuantian.Tang@freescale.com (2013-05-22 01:22:19)
> From: Tang Yuantian <yuantian.tang@freescale.com>
> =

> The compatible string of clock is changed from *-2 to *-2.0
> on chassis 2. So updated it accordingly.
> =

> Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>

Taken into clk-next.

Regards,
Mike

> ---
>  drivers/clk/clk-ppc-corenet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> =

> diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c
> index a2d483f..e958707 100644
> --- a/drivers/clk/clk-ppc-corenet.c
> +++ b/drivers/clk/clk-ppc-corenet.c
> @@ -260,7 +260,7 @@ static int __init ppc_corenet_clk_probe(struct platfo=
rm_device *pdev)
>  =

>  static const struct of_device_id ppc_clk_ids[] __initconst =3D {
>         { .compatible =3D "fsl,qoriq-clockgen-1.0", },
> -       { .compatible =3D "fsl,qoriq-clockgen-2", },
> +       { .compatible =3D "fsl,qoriq-clockgen-2.0", },
>         {}
>  };
>  =

> -- =

> 1.8.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clk/mpc85xx: Update the compatible string
  2013-05-30 18:57 ` Mike Turquette
@ 2013-05-30 19:21   ` Mike Turquette
  2013-05-30 19:26     ` Kumar Gala
  0 siblings, 1 reply; 5+ messages in thread
From: Mike Turquette @ 2013-05-30 19:21 UTC (permalink / raw)
  To: Mike Turquette, Yuantian.Tang
  Cc: Tang Yuantian, devicetree-discuss, linuxppc-dev

Quoting Mike Turquette (2013-05-30 11:57:32)
> Quoting Yuantian.Tang@freescale.com (2013-05-22 01:22:19)
> > From: Tang Yuantian <yuantian.tang@freescale.com>
> > =

> > The compatible string of clock is changed from *-2 to *-2.0
> > on chassis 2. So updated it accordingly.
> > =

> > Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
> =

> Taken into clk-next.
> =


One small nitpick.  I updated the $SUBJECT to:

clk: mpc85xx: Update the compatible string

The difference being "clk: mpc85xx:" versus "clk/mpc85xx:".  Please use
the former format in the future.

Thanks,
Mike

> Regards,
> Mike
> =

> > ---
> >  drivers/clk/clk-ppc-corenet.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > =

> > diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corene=
t.c
> > index a2d483f..e958707 100644
> > --- a/drivers/clk/clk-ppc-corenet.c
> > +++ b/drivers/clk/clk-ppc-corenet.c
> > @@ -260,7 +260,7 @@ static int __init ppc_corenet_clk_probe(struct plat=
form_device *pdev)
> >  =

> >  static const struct of_device_id ppc_clk_ids[] __initconst =3D {
> >         { .compatible =3D "fsl,qoriq-clockgen-1.0", },
> > -       { .compatible =3D "fsl,qoriq-clockgen-2", },
> > +       { .compatible =3D "fsl,qoriq-clockgen-2.0", },
> >         {}
> >  };
> >  =

> > -- =

> > 1.8.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clk/mpc85xx: Update the compatible string
  2013-05-30 19:21   ` Mike Turquette
@ 2013-05-30 19:26     ` Kumar Gala
  2013-05-30 19:44       ` Mike Turquette
  0 siblings, 1 reply; 5+ messages in thread
From: Kumar Gala @ 2013-05-30 19:26 UTC (permalink / raw)
  To: Mike Turquette; +Cc: Yuantian.Tang, devicetree-discuss, linuxppc-dev


On May 30, 2013, at 2:21 PM, Mike Turquette wrote:

> Quoting Mike Turquette (2013-05-30 11:57:32)
>> Quoting Yuantian.Tang@freescale.com (2013-05-22 01:22:19)
>>> From: Tang Yuantian <yuantian.tang@freescale.com>
>>>=20
>>> The compatible string of clock is changed from *-2 to *-2.0
>>> on chassis 2. So updated it accordingly.
>>>=20
>>> Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
>>=20
>> Taken into clk-next.
>>=20
>=20
> One small nitpick.  I updated the $SUBJECT to:
>=20
> clk: mpc85xx: Update the compatible string
>=20
> The difference being "clk: mpc85xx:" versus "clk/mpc85xx:".  Please =
use
> the former format in the future.
>=20
> Thanks,
> Mike

Mike,

If clk-ppc-corenet.c went into v3.10, than I think this fix is needed =
there and shouldn't wait til v3.11

- k=

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clk/mpc85xx: Update the compatible string
  2013-05-30 19:26     ` Kumar Gala
@ 2013-05-30 19:44       ` Mike Turquette
  0 siblings, 0 replies; 5+ messages in thread
From: Mike Turquette @ 2013-05-30 19:44 UTC (permalink / raw)
  To: Kumar Gala; +Cc: Yuantian.Tang, devicetree-discuss, linuxppc-dev

Quoting Kumar Gala (2013-05-30 12:26:38)
> On May 30, 2013, at 2:21 PM, Mike Turquette wrote:
> =

> > Quoting Mike Turquette (2013-05-30 11:57:32)
> >> Quoting Yuantian.Tang@freescale.com (2013-05-22 01:22:19)
> >>> From: Tang Yuantian <yuantian.tang@freescale.com>
> >>> =

> >>> The compatible string of clock is changed from *-2 to *-2.0
> >>> on chassis 2. So updated it accordingly.
> >>> =

> >>> Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
> >> =

> >> Taken into clk-next.
> >> =

> > =

> > One small nitpick.  I updated the $SUBJECT to:
> > =

> > clk: mpc85xx: Update the compatible string
> > =

> > The difference being "clk: mpc85xx:" versus "clk/mpc85xx:".  Please use
> > the former format in the future.
> > =

> > Thanks,
> > Mike
> =

> Mike,
> =

> If clk-ppc-corenet.c went into v3.10, than I think this fix is needed the=
re and shouldn't wait til v3.11
> =


clk-ppc-corenet.c is first introduced in the current clk-next branch.
It is not merged into Linus' tree yet.

Regards,
Mike

> - k

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-05-30 19:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-22  8:22 [PATCH] clk/mpc85xx: Update the compatible string Yuantian.Tang
2013-05-30 18:57 ` Mike Turquette
2013-05-30 19:21   ` Mike Turquette
2013-05-30 19:26     ` Kumar Gala
2013-05-30 19:44       ` Mike Turquette

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).