From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 25 Jun 2013 11:50:57 +1000 From: Michael Ellerman To: Nathan Fontenot Subject: Re: [PATCH] Do not update sysfs cpu registration from invalid context Message-ID: <20130625015057.GC14051@concordia> References: <51C8543F.6080905@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <51C8543F.6080905@linux.vnet.ibm.com> Cc: linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Jun 24, 2013 at 09:14:23AM -0500, Nathan Fontenot wrote: > The topology update code that updates the cpu node registration in sysfs > should not be called while in stop_machine(). The register/unregister > calls take a lock and may sleep. > > This patch moves these calls outside of the call to stop_machine(). What happens? Do we lockup or do you just get a warning? And what commit introduced the breakage? cheers