From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 28 Jun 2013 00:23:09 +1000 From: Michael Ellerman To: Runzhen Wang Subject: Re: [PATCH v2 2/2] perf tools: Make Power7 events available for perf Message-ID: <20130627142309.GB13867@concordia> References: <1372170933-4538-1-git-send-email-runzhen@linux.vnet.ibm.com> <1372170933-4538-3-git-send-email-runzhen@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1372170933-4538-3-git-send-email-runzhen@linux.vnet.ibm.com> Cc: linux-kernel@vger.kernel.org, xiaoguangrong@linux.vnet.ibm.com, acme@redhat.com, paulus@samba.org, sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Jun 25, 2013 at 10:35:33PM +0800, Runzhen Wang wrote: > Power7 supports over 530 different perf events but only a small > subset of these can be specified by name, for the remaining > events, we must specify them by their raw code: Hi Runzhen, This is looking good. Sorry one last request below ... > diff --git a/arch/powerpc/perf/power7-events-list.h b/arch/powerpc/perf/power7-events-list.h > new file mode 100644 > index 0000000..a67e8a9 > --- /dev/null > +++ b/arch/powerpc/perf/power7-events-list.h > @@ -0,0 +1,548 @@ .. > + > +EVENT(PM_IC_DEMAND_L2_BR_ALL, 0x4898) > +EVENT(PM_GCT_UTIL_7_TO_10_SLOTS, 0x20a0) > +EVENT(PM_PMC2_SAVED, 0x10022) > +EVENT(PM_CMPLU_STALL_DFU, 0x2003c) > +EVENT(PM_VSU0_16FLOP, 0xa0a4) Can you add a leading zero to all the events that don't have a PMC, so that they all line up vertically. It makes it a lot easier to scan the list visually. eg: EVENT(PM_IC_DEMAND_L2_BR_ALL, 0x04898) EVENT(PM_GCT_UTIL_7_TO_10_SLOTS, 0x020a0) EVENT(PM_PMC2_SAVED, 0x10022) EVENT(PM_CMPLU_STALL_DFU, 0x2003c) EVENT(PM_VSU0_16FLOP, 0x0a0a4) cheers