From: Michael Ellerman <michael@ellerman.id.au>
To: Kevin Hao <haokexin@gmail.com>
Cc: linuxppc <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 1/2] powerpc/math-emu: remove the dead code in math.c
Date: Wed, 10 Jul 2013 12:01:33 +1000 [thread overview]
Message-ID: <20130710020132.GA7491@concordia> (raw)
In-Reply-To: <1373420623-24869-2-git-send-email-haokexin@gmail.com>
On Wed, Jul 10, 2013 at 09:43:42AM +0800, Kevin Hao wrote:
> The math.c is only built when CONFIG_MATH_EMULATION is enabled.
> So we would never get into the case that CONFIG_MATH_EMULATION
> is not defined in this file.
Any idea why we have that there? ie. have the config symbols changed
over time or was this always dead code?
cheers
next prev parent reply other threads:[~2013-07-10 2:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 1:43 [PATCH 0/2] powerpc/math-emu: two minor cleanup patches for math.c Kevin Hao
2013-07-10 1:43 ` [PATCH 1/2] powerpc/math-emu: remove the dead code in math.c Kevin Hao
2013-07-10 2:01 ` Michael Ellerman [this message]
2013-07-10 2:23 ` Kevin Hao
2013-07-10 3:25 ` Michael Ellerman
2013-07-10 3:46 ` Kevin Hao
2013-07-10 3:48 ` Benjamin Herrenschmidt
2013-07-10 1:43 ` [PATCH 2/2] powerpc/math-emu: remove the unneeded check for CONFIG_MATH_EMULATION " Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130710020132.GA7491@concordia \
--to=michael@ellerman.id.au \
--cc=haokexin@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).