From: Anton Blanchard <anton@samba.org>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Scott Wood <scottwood@freescale.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] module: ppc64 module CRC relocation fix causes perf issues
Date: Fri, 26 Jul 2013 11:19:13 +1000 [thread overview]
Message-ID: <20130726111913.201ab9d4@kryten> (raw)
In-Reply-To: <20130725130212.GA19366@hmsreliant.think-freely.org>
Hi Neil,
> Sorry I'm a bit late to the thread, I've ben swamped. Has someone
> tested this with kexec/kdump? Thats why the origional patch was
> created, because when kexec loads the kernel at a different physical
> address, the relocations messed with the module crc's, and modules
> couldn't load during the kexec boot. Assuming that kernaddr_start
> gets set appropriately during boot, using PHYSICAL_START should be
> fine, but I wanted to check, and don't currently have access to a
> powerpc system to do so. Neil
I tested a relocatable kernel forced to run at a non zero physical
address (ie basically kdump). I verified CRCs were bad with your
original patch backed out, and were good with this patch applied.
Anton
next prev parent reply other threads:[~2013-07-26 1:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 4:04 [PATCH] module: ppc64 module CRC relocation fix causes perf issues Anton Blanchard
2013-07-15 4:39 ` Rusty Russell
2013-07-15 8:47 ` Benjamin Herrenschmidt
2013-07-16 22:40 ` Scott Wood
2013-07-17 0:04 ` Benjamin Herrenschmidt
2013-07-17 0:08 ` Scott Wood
2013-07-18 4:00 ` Anton Blanchard
2013-07-19 22:59 ` Scott Wood
2013-07-23 13:30 ` Michael Ellerman
2013-07-24 19:22 ` Scott Wood
2013-07-24 22:34 ` Anton Blanchard
2013-07-24 23:14 ` Benjamin Herrenschmidt
2013-07-25 13:02 ` Neil Horman
2013-07-26 1:19 ` Anton Blanchard [this message]
2013-07-26 13:11 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130726111913.201ab9d4@kryten \
--to=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nhorman@tuxdriver.com \
--cc=paulus@samba.org \
--cc=rusty@rustcorp.com.au \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).