From: Anton Vorontsov <anton@enomsg.org>
To: Scott Wood <scottwood@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Zhang Haijun-B42677 <B42677@freescale.com>,
Fleming Andy-AFLEMING <afleming@freescale.com>,
"cjb@laptop.org" <cjb@laptop.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 2/2] mmc: esdhc: get voltage from dts file
Date: Fri, 26 Jul 2013 12:06:08 -0700 [thread overview]
Message-ID: <20130726190608.GA14216@lizard> (raw)
In-Reply-To: <1374547294.15592.22@snotra>
On Mon, Jul 22, 2013 at 09:41:34PM -0500, Scott Wood wrote:
[...]
> >> > +static void esdhc_get_voltage(struct sdhci_host *host,
> >> > + struct platform_device *pdev)
> >> > +{
....
> >> > +}
> >>
> >> Don't duplicate this code. Move it somewhere common and share it.
> >[Haijun Wrote:] So, move it drivers/mmc/host/sdhci-pltfm.c and
> >share it as
> >Sdhc_get_voltage()....?
>
> I'll let the MMC maintainer say what the appropriate place would
> be... Don't capitalize the function name, though. :-)
Somewhere in drivers/mmc/core/core.c, near mmc_vddrange_to_ocrmask() would
be most appropriate, IMO. #ifdef CONFIG_OF would be needed, though.
Thanks,
Anton
next prev parent reply other threads:[~2013-07-26 19:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 7:53 [PATCH 1/2] Powerpc: Add voltage ranges support for T4 Haijun Zhang
2013-07-22 7:53 ` [PATCH 2/2] mmc: esdhc: get voltage from dts file Haijun Zhang
2013-07-22 17:40 ` Scott Wood
2013-07-23 2:38 ` Zhang Haijun-B42677
2013-07-23 2:41 ` Scott Wood
2013-07-23 3:41 ` Zhang Haijun-B42677
2013-07-26 19:06 ` Anton Vorontsov [this message]
2013-07-22 9:47 ` [PATCH 1/2] Powerpc: Add voltage ranges support for T4 Wrobel Heinz-R39252
2013-07-22 14:39 ` Kumar Gala
2013-07-23 2:05 ` Zhang Haijun-B42677
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130726190608.GA14216@lizard \
--to=anton@enomsg.org \
--cc=B07421@freescale.com \
--cc=B42677@freescale.com \
--cc=afleming@freescale.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).