* [PATCH 2/4] Device Tree bindings for Freescale TDM controller
2013-03-07 11:27 [PATCH 1/4] Device tree entry for Freescale TDM controller Sandeep Singh
@ 2013-03-07 11:27 ` Sandeep Singh
2013-03-07 11:27 ` [PATCH 3/4] TDM Device Tree entries for various Freescale Platforms Sandeep Singh
` (4 subsequent siblings)
5 siblings, 0 replies; 14+ messages in thread
From: Sandeep Singh @ 2013-03-07 11:27 UTC (permalink / raw)
To: linuxppc-dev, linux-arm-kernel; +Cc: Sandeep Singh, Poonam Aggrwal
This controller is available on many Freescale SOCs like MPC8315, P1020, P1010,
P1022 and P1024
Signed-off-by: Sandeep Singh <Sandeep@freescale.com>
Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
---
Documentation/devicetree/bindings/tdm/fsl-tdm.txt | 65 +++++++++++++++++++++
1 files changed, 65 insertions(+), 0 deletions(-)
create mode 100644 Documentation/devicetree/bindings/tdm/fsl-tdm.txt
diff --git a/Documentation/devicetree/bindings/tdm/fsl-tdm.txt b/Documentation/devicetree/bindings/tdm/fsl-tdm.txt
new file mode 100644
index 0000000..1258b89
--- /dev/null
+++ b/Documentation/devicetree/bindings/tdm/fsl-tdm.txt
@@ -0,0 +1,65 @@
+=====================================================================
+TDM Device Tree Binding
+Copyright (C) 2012 Freescale Semiconductor Inc.
+
+NOTE: The bindings described in this document are preliminary
+and subject to change.
+
+=====================================================================
+TDM (Time Division Multiplexing)
+
+DESCRIPTION
+
+The TDM is full duplex serial port designed to allow various devices including
+digital signal processors (DSPs) to communicate with a variety of serial devices
+including industry standard framers, codecs, other DSPs and microprocessors.
+
+The below properties describe the device tree bindings for Freescale TDM
+controller.
+This TDM controller is available on various Freescale Processors like
+MPC8313, P1020, P1022 and P1010.
+
+PROPERTIES
+
+ - compatible
+ Usage: required
+ Value type: <string>
+ Definition: Should contain "fsl,tdm1.0".
+
+ - reg
+ Usage: required
+ Definition: A standard property. The first reg specifier describes the
+ TDM registers, and the second describes the TDM DMAC registers.
+
+ - clock-frequency
+ Usage: optional
+ Value type: <u32 or u64>
+ Definition: The frequency at which the TDM block is operating.
+
+ - interrupts
+ Usage: required
+ Definition: Definition: Two interrupt specifiers. The first is TDM
+ error, and the second is TDM EMAC.
+
+ - phy-handle
+ Usage: optional
+ Value type: <phandle>
+ Definition: Phandle of the line controller node or framer node eg. SLIC,
+ E1/T1 etc.
+
+ - fsl,max-time-slots
+ Usage: required
+ Value type: <u32>
+ Definition: Maximum number of 8-bit time slots in one TDM frame.
+ This is the maximum number which TDM hardware supports.
+
+EXAMPLE
+
+ tdm@16000 {
+ compatible = "fsl,tdm1.0";
+ reg = <0x16000 0x200 0x2c000 0x2000>;
+ clock-frequency = <0>;
+ interrupts = <16 8 62 8>;
+ phy-handle = <&zarlink1>;
+ fsl,max-time-slots = <128>;
+ };
--
1.7.6.GIT
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 3/4] TDM Device Tree entries for various Freescale Platforms
2013-03-07 11:27 [PATCH 1/4] Device tree entry for Freescale TDM controller Sandeep Singh
2013-03-07 11:27 ` [PATCH 2/4] Device Tree bindings " Sandeep Singh
@ 2013-03-07 11:27 ` Sandeep Singh
2013-03-08 16:47 ` Timur Tabi
2013-03-07 11:27 ` [PATCH 4/4] Added device tree entries for Legerity SLIC node on " Sandeep Singh
` (3 subsequent siblings)
5 siblings, 1 reply; 14+ messages in thread
From: Sandeep Singh @ 2013-03-07 11:27 UTC (permalink / raw)
To: linuxppc-dev, linux-arm-kernel; +Cc: Sandeep Singh, Poonam Aggrwal
P1010RDB, P1020RDB, P1020MBG-PC, P1022DS, P1020RDB-PC and P1024RDB
In this Patch:
1. TDM node included in <silicon>.dtsi files.
2. Disabled TDM in 36bit configurations because of limitations
in TDM hardware block, details mentioned below.
Details of 36bit h/w limitaion:
---------------------------------
TDM DMAC IP does not support more than 32b address. To address memory regions
more than 4GB, 4 bits of address were provided in GUTs, which are appended to
txns initiated by TDM DMAC. These 4 bits are appended irrespective of the
region addressed. When TDM works in DMA mode, the DMA need to access DDR as
well as TDM FIFO in CCSR space. So this poses a restriction that if memory
region above 4GB need to be accessed, CCSR space should also be mapped into
that 4GB region.
In this case DDR is at at first 4G (starting from 0) and CCSR is at
different 4G (0xfffe00000), hence the issue.
Signed-off-by: Sandeep Singh <Sandeep@freescale.com>
Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
---
arch/powerpc/boot/dts/fsl/p1010si-post.dtsi | 3 ++-
arch/powerpc/boot/dts/fsl/p1020si-post.dtsi | 1 +
arch/powerpc/boot/dts/fsl/p1022si-post.dtsi | 1 +
arch/powerpc/boot/dts/p1010rdb_36b.dts | 3 +++
arch/powerpc/boot/dts/p1020mbg-pc_36b.dts | 3 +++
arch/powerpc/boot/dts/p1020rdb-pc_36b.dts | 3 +++
arch/powerpc/boot/dts/p1020rdb_36b.dts | 3 +++
arch/powerpc/boot/dts/p1022ds_36b.dts | 3 +++
arch/powerpc/boot/dts/p1024rdb_36b.dts | 3 +++
9 files changed, 22 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi b/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi
index 0bde9ee..15c74a2 100644
--- a/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi
@@ -1,7 +1,7 @@
/*
* P1010/P1014 Silicon/SoC Device Tree Source (post include)
*
- * Copyright 2011 Freescale Semiconductor Inc.
+ * Copyright 2011-2012 Freescale Semiconductor Inc.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
@@ -132,6 +132,7 @@
/include/ "pq3-gpio-0.dtsi"
/include/ "pq3-sata2-0.dtsi"
/include/ "pq3-sata2-1.dtsi"
+/include/ "pq3-tdm1.0-0.dtsi"
can0: can@1c000 {
compatible = "fsl,p1010-flexcan";
diff --git a/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi b/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi
index 68cc5e7..684f664 100644
--- a/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi
@@ -131,6 +131,7 @@
};
/include/ "pq3-gpio-0.dtsi"
+/include/ "pq3-tdm1.0-0.dtsi"
L2: l2-cache-controller@20000 {
compatible = "fsl,p1020-l2-cache-controller";
diff --git a/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi b/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
index 06216b8..4016e45 100644
--- a/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
@@ -190,6 +190,7 @@
fsl,fifo-depth = <15>;
};
+/include/ "pq3-tdm1.0-0.dtsi"
/include/ "pq3-sata2-0.dtsi"
/include/ "pq3-sata2-1.dtsi"
diff --git a/arch/powerpc/boot/dts/p1010rdb_36b.dts b/arch/powerpc/boot/dts/p1010rdb_36b.dts
index 64776f4..e159b42 100644
--- a/arch/powerpc/boot/dts/p1010rdb_36b.dts
+++ b/arch/powerpc/boot/dts/p1010rdb_36b.dts
@@ -52,6 +52,9 @@
board_soc: soc: soc@fffe00000 {
ranges = <0x0 0xf 0xffe00000 0x100000>;
+ tdm@16000 {
+ status = "disabled";
+ };
};
pci0: pcie@fffe09000 {
diff --git a/arch/powerpc/boot/dts/p1020mbg-pc_36b.dts b/arch/powerpc/boot/dts/p1020mbg-pc_36b.dts
index 9e9f401..416e1a7 100644
--- a/arch/powerpc/boot/dts/p1020mbg-pc_36b.dts
+++ b/arch/powerpc/boot/dts/p1020mbg-pc_36b.dts
@@ -52,6 +52,9 @@
soc: soc@fffe00000 {
ranges = <0x0 0xf 0xffe00000 0x100000>;
+ tdm@16000 {
+ status = "disabled";
+ };
};
pci0: pcie@fffe09000 {
diff --git a/arch/powerpc/boot/dts/p1020rdb-pc_36b.dts b/arch/powerpc/boot/dts/p1020rdb-pc_36b.dts
index 5237da7..a1861d6 100644
--- a/arch/powerpc/boot/dts/p1020rdb-pc_36b.dts
+++ b/arch/powerpc/boot/dts/p1020rdb-pc_36b.dts
@@ -53,6 +53,9 @@
soc: soc@fffe00000 {
ranges = <0x0 0xf 0xffe00000 0x100000>;
+ tdm@16000 {
+ status = "disabled";
+ };
};
pci0: pcie@fffe09000 {
diff --git a/arch/powerpc/boot/dts/p1020rdb_36b.dts b/arch/powerpc/boot/dts/p1020rdb_36b.dts
index bdbdb60..7bac196 100644
--- a/arch/powerpc/boot/dts/p1020rdb_36b.dts
+++ b/arch/powerpc/boot/dts/p1020rdb_36b.dts
@@ -29,6 +29,9 @@
board_soc: soc: soc@fffe00000 {
ranges = <0x0 0xf 0xffe00000 0x100000>;
+ tdm@16000 {
+ status = "disabled";
+ };
};
pci0: pcie@fffe09000 {
diff --git a/arch/powerpc/boot/dts/p1022ds_36b.dts b/arch/powerpc/boot/dts/p1022ds_36b.dts
index f7aacce..024ea40 100644
--- a/arch/powerpc/boot/dts/p1022ds_36b.dts
+++ b/arch/powerpc/boot/dts/p1022ds_36b.dts
@@ -51,6 +51,9 @@
board_soc: soc: soc@fffe00000 {
ranges = <0x0 0xf 0xffe00000 0x100000>;
+ tdm@16000 {
+ status = "disabled";
+ };
};
pci0: pcie@fffe09000 {
diff --git a/arch/powerpc/boot/dts/p1024rdb_36b.dts b/arch/powerpc/boot/dts/p1024rdb_36b.dts
index 3656825..b113229 100644
--- a/arch/powerpc/boot/dts/p1024rdb_36b.dts
+++ b/arch/powerpc/boot/dts/p1024rdb_36b.dts
@@ -49,6 +49,9 @@
soc: soc@fffe00000 {
ranges = <0x0 0xf 0xffe00000 0x100000>;
+ tdm@16000 {
+ status = "disabled";
+ };
};
pci0: pcie@fffe09000 {
--
1.7.6.GIT
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 3/4] TDM Device Tree entries for various Freescale Platforms
2013-03-07 11:27 ` [PATCH 3/4] TDM Device Tree entries for various Freescale Platforms Sandeep Singh
@ 2013-03-08 16:47 ` Timur Tabi
2013-03-08 16:47 ` Timur Tabi
2013-03-11 9:27 ` Singh Sandeep-B37400
0 siblings, 2 replies; 14+ messages in thread
From: Timur Tabi @ 2013-03-08 16:47 UTC (permalink / raw)
To: Sandeep Singh; +Cc: Poonam Aggrwal, linuxppc-dev
On Thu, Mar 7, 2013 at 5:27 AM, Sandeep Singh <Sandeep@freescale.com> wrote:
> arch/powerpc/boot/dts/p1022ds_36b.dts | 3 +++
You forgot to update p1022ds_3b.dts.
> - * Copyright 2011 Freescale Semiconductor Inc.
> + * Copyright 2011-2012 Freescale Semiconductor Inc.
Do not update the copyright year in patches.
--
Timur Tabi
Linux kernel developer at Freescale
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/4] TDM Device Tree entries for various Freescale Platforms
2013-03-08 16:47 ` Timur Tabi
@ 2013-03-08 16:47 ` Timur Tabi
2013-03-11 9:27 ` Singh Sandeep-B37400
1 sibling, 0 replies; 14+ messages in thread
From: Timur Tabi @ 2013-03-08 16:47 UTC (permalink / raw)
To: Sandeep Singh, linuxppc-dev, Poonam Aggrwal
On Fri, Mar 8, 2013 at 10:47 AM, Timur Tabi <timur@tabi.org> wrote:
>
> You forgot to update p1022ds_3b.dts.
I meant p1022ds_32b.dts -- the 32-bit DTS for the P1022DS.
--
Timur Tabi
Linux kernel developer at Freescale
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH 3/4] TDM Device Tree entries for various Freescale Platforms
2013-03-08 16:47 ` Timur Tabi
2013-03-08 16:47 ` Timur Tabi
@ 2013-03-11 9:27 ` Singh Sandeep-B37400
1 sibling, 0 replies; 14+ messages in thread
From: Singh Sandeep-B37400 @ 2013-03-11 9:27 UTC (permalink / raw)
To: Timur Tabi; +Cc: Aggrwal Poonam-B10812, linuxppc-dev@lists.ozlabs.org
> -----Original Message-----
> From: Timur Tabi [mailto:timur@tabi.org]
> Sent: Friday, March 08, 2013 10:17 PM
> To: Singh Sandeep-B37400
> Cc: linuxppc-dev@lists.ozlabs.org; Aggrwal Poonam-B10812
> Subject: Re: [PATCH 3/4] TDM Device Tree entries for various Freescale
> Platforms
>=20
> On Thu, Mar 7, 2013 at 5:27 AM, Sandeep Singh <Sandeep@freescale.com>
> wrote:
> > arch/powerpc/boot/dts/p1022ds_36b.dts | 3 +++
>=20
> You forgot to update p1022ds_3b.dts.
p1022ds_32b.dts includes "fsl/p1022si-post.dtsi" which is getting updated.
>=20
> > - * Copyright 2011 Freescale Semiconductor Inc.
> > + * Copyright 2011-2012 Freescale Semiconductor Inc.
>=20
> Do not update the copyright year in patches.
Ok, will correct this.
>=20
> --
> Timur Tabi
> Linux kernel developer at Freescale
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 4/4] Added device tree entries for Legerity SLIC node on various Freescale Platforms
2013-03-07 11:27 [PATCH 1/4] Device tree entry for Freescale TDM controller Sandeep Singh
2013-03-07 11:27 ` [PATCH 2/4] Device Tree bindings " Sandeep Singh
2013-03-07 11:27 ` [PATCH 3/4] TDM Device Tree entries for various Freescale Platforms Sandeep Singh
@ 2013-03-07 11:27 ` Sandeep Singh
2013-07-30 22:40 ` [4/4] " Scott Wood
2013-03-07 13:34 ` [PATCH 1/4] Device tree entry for Freescale TDM controller Russell King - ARM Linux
` (2 subsequent siblings)
5 siblings, 1 reply; 14+ messages in thread
From: Sandeep Singh @ 2013-03-07 11:27 UTC (permalink / raw)
To: linuxppc-dev, linux-arm-kernel; +Cc: Sandeep Singh, Poonam Aggrwal
SLIC device is connected on SPI bus on these platforms
Signed-off-by: Sandeep Singh <Sandeep@freescale.com>
Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
---
arch/powerpc/boot/dts/p1010rdb.dtsi | 13 ++++++++++++-
arch/powerpc/boot/dts/p1020mbg-pc.dtsi | 19 +++++++++++++++++++
arch/powerpc/boot/dts/p1020rdb-pc.dtsi | 18 ++++++++++++++++++
arch/powerpc/boot/dts/p1020rdb.dtsi | 17 +++++++++++++++++
arch/powerpc/boot/dts/p1022ds.dtsi | 17 +++++++++++++++++
arch/powerpc/boot/dts/p1024rdb.dtsi | 18 ++++++++++++++++++
6 files changed, 101 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/boot/dts/p1010rdb.dtsi b/arch/powerpc/boot/dts/p1010rdb.dtsi
index ec7c27a..b0a5908 100644
--- a/arch/powerpc/boot/dts/p1010rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1010rdb.dtsi
@@ -1,7 +1,7 @@
/*
* P1010 RDB Device Tree Source stub (no addresses or top-level ranges)
*
- * Copyright 2011 Freescale Semiconductor Inc.
+ * Copyright 2011-2012 Freescale Semiconductor Inc.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
@@ -184,8 +184,19 @@
label = "SPI Flash JFFS2 RFS";
};
};
+
+ tdm_phy_0: slic@0 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <0>;
+ spi-max-frequency = <8000000>;
+ };
};
+ tdm@16000 {
+ num-phy = <1>;
+ phy-handle = <&tdm_phy_0>;
+ };
+
usb@22000 {
phy_type = "utmi";
dr_mode = "host";
diff --git a/arch/powerpc/boot/dts/p1020mbg-pc.dtsi b/arch/powerpc/boot/dts/p1020mbg-pc.dtsi
index a24699c..9119387 100644
--- a/arch/powerpc/boot/dts/p1020mbg-pc.dtsi
+++ b/arch/powerpc/boot/dts/p1020mbg-pc.dtsi
@@ -93,6 +93,25 @@
};
};
+ spi@7000 {
+ tdm_phy_0: slic@0 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <1>;
+ spi-max-frequency = <8000000>;
+ };
+
+ tdm_phy_1: slic@1 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <2>;
+ spi-max-frequency = <8000000>;
+ };
+ };
+
+ tdm@16000 {
+ num-phy = <2>;
+ phy-handle = <&tdm_phy_0>, <&tdm_phy_1>;
+ };
+
mdio@24000 {
phy0: ethernet-phy@0 {
interrupts = <3 1 0 0>;
diff --git a/arch/powerpc/boot/dts/p1020rdb-pc.dtsi b/arch/powerpc/boot/dts/p1020rdb-pc.dtsi
index c952cd3..3a7fdd9 100644
--- a/arch/powerpc/boot/dts/p1020rdb-pc.dtsi
+++ b/arch/powerpc/boot/dts/p1020rdb-pc.dtsi
@@ -186,6 +186,24 @@
label = "file system jffs2";
};
};
+
+ tdm_phy_0: slic@0 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <1>;
+ spi-max-frequency = <8000000>;
+ };
+
+ tdm_phy_1: slic@1 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <2>;
+ spi-max-frequency = <8000000>;
+ };
+
+ };
+
+ tdm@16000 {
+ num-phy = <2>;
+ phy-handle = <&tdm_phy_0>, <&tdm_phy_1>;
};
usb@22000 {
diff --git a/arch/powerpc/boot/dts/p1020rdb.dtsi b/arch/powerpc/boot/dts/p1020rdb.dtsi
index 1fb7e0e..f1a3431 100644
--- a/arch/powerpc/boot/dts/p1020rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1020rdb.dtsi
@@ -186,6 +186,23 @@
label = "file system jffs2";
};
};
+
+ tdm_phy_0: slic@0 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <1>;
+ spi-max-frequency = <8000000>;
+ };
+
+ tdm_phy_1: slic@1 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <2>;
+ spi-max-frequency = <8000000>;
+ };
+ };
+
+ tdm@16000 {
+ num-phy = <2>;
+ phy-handle = <&tdm_phy_0>, <&tdm_phy_1>;
};
usb@22000 {
diff --git a/arch/powerpc/boot/dts/p1022ds.dtsi b/arch/powerpc/boot/dts/p1022ds.dtsi
index 873da35..af2d4e1 100644
--- a/arch/powerpc/boot/dts/p1022ds.dtsi
+++ b/arch/powerpc/boot/dts/p1022ds.dtsi
@@ -183,6 +183,18 @@
reg = <0x00700000 0x00900000>;
};
};
+
+ tdm_phy_0: slic@0 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <1>;
+ spi-max-frequency = <8000000>;
+ };
+
+ tdm_phy_1: slic@1 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <2>;
+ spi-max-frequency = <8000000>;
+ };
};
ssi@15000 {
@@ -191,6 +203,11 @@
fsl,ssi-asynchronous;
};
+ tdm@16000 {
+ num-phy = <2>;
+ phy-handle = <&tdm_phy_0>, <&tdm_phy_1>;
+ };
+
usb@22000 {
phy_type = "ulpi";
};
diff --git a/arch/powerpc/boot/dts/p1024rdb.dtsi b/arch/powerpc/boot/dts/p1024rdb.dtsi
index b05dcb4..cec36a3 100644
--- a/arch/powerpc/boot/dts/p1024rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1024rdb.dtsi
@@ -164,6 +164,19 @@
label = "SPI JFFS2 RFS";
};
};
+
+ tdm_phy_0: slic@0 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <1>;
+ spi-max-frequency = <8000000>;
+ };
+
+ tdm_phy_1: slic@1 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <2>;
+ spi-max-frequency = <8000000>;
+ };
+
};
i2c@3000 {
@@ -173,6 +186,11 @@
};
};
+ tdm@16000 {
+ num-phy = <2>;
+ phy-handle = <&tdm_phy_0>, <&tdm_phy_1>;
+ };
+
usb@22000 {
phy_type = "ulpi";
};
--
1.7.6.GIT
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [4/4] Added device tree entries for Legerity SLIC node on various Freescale Platforms
2013-03-07 11:27 ` [PATCH 4/4] Added device tree entries for Legerity SLIC node on " Sandeep Singh
@ 2013-07-30 22:40 ` Scott Wood
0 siblings, 0 replies; 14+ messages in thread
From: Scott Wood @ 2013-07-30 22:40 UTC (permalink / raw)
To: Sandeep Singh; +Cc: Poonam Aggrwal, linuxppc-dev, linux-arm-kernel
On Thu, Mar 07, 2013 at 04:57:48PM +0530, Sandeep Singh wrote:
> diff --git a/arch/powerpc/boot/dts/p1024rdb.dtsi b/arch/powerpc/boot/dts/p1024rdb.dtsi
> index b05dcb4..cec36a3 100644
> --- a/arch/powerpc/boot/dts/p1024rdb.dtsi
> +++ b/arch/powerpc/boot/dts/p1024rdb.dtsi
> @@ -164,6 +164,19 @@
> label = "SPI JFFS2 RFS";
> };
> };
> +
> + tdm_phy_0: slic@0 {
> + compatible = "zarlink,le88266", "tdm-phy-slic";
> + reg = <1>;
> + spi-max-frequency = <8000000>;
> + };
> +
> + tdm_phy_1: slic@1 {
> + compatible = "zarlink,le88266", "tdm-phy-slic";
> + reg = <2>;
> + spi-max-frequency = <8000000>;
> + };
> +
> };
>
> i2c@3000 {
> @@ -173,6 +186,11 @@
> };
> };
>
> + tdm@16000 {
> + num-phy = <2>;
> + phy-handle = <&tdm_phy_0>, <&tdm_phy_1>;
> + };
> +
> usb@22000 {
> phy_type = "ulpi";
> };
Whitespace
What is "tdm-phy-slic"? "num-phy"? Document these in the binding and
use proper vendor prefixes.
Why "<&tdm_phy_0>, <&tdm_phy_1>" rather than "<&tdm_phy_0 &tdm_phy_1>"?
And can you just use the length of phy-handle rather than having a
separate num-phy property?
-Scott
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/4] Device tree entry for Freescale TDM controller
2013-03-07 11:27 [PATCH 1/4] Device tree entry for Freescale TDM controller Sandeep Singh
` (2 preceding siblings ...)
2013-03-07 11:27 ` [PATCH 4/4] Added device tree entries for Legerity SLIC node on " Sandeep Singh
@ 2013-03-07 13:34 ` Russell King - ARM Linux
2013-03-13 5:17 ` Singh Sandeep-B37400
2013-03-20 10:51 ` Singh Sandeep-B37400
2013-06-28 22:15 ` [1/4] " Scott Wood
5 siblings, 1 reply; 14+ messages in thread
From: Russell King - ARM Linux @ 2013-03-07 13:34 UTC (permalink / raw)
To: Sandeep Singh; +Cc: Poonam Aggrwal, linuxppc-dev, linux-arm-kernel
I know I'm probably missing something... but... why are these patches
copied to the ARM list? They appear to be PowerPC patches.
On Thu, Mar 07, 2013 at 04:57:45PM +0530, Sandeep Singh wrote:
> Added dtsi file for Freescale TDM controller.
> This controller is available on many Freescale SOCs like MPC8315, P1020, P1010,
> P1022 and P1024
> Signed-off-by: Sandeep Singh <Sandeep@freescale.com>
> Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
> ---
> arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi | 42 +++++++++++++++++++++++++++
> 1 files changed, 42 insertions(+), 0 deletions(-)
> create mode 100644 arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi
>
> diff --git a/arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi b/arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi
> new file mode 100644
> index 0000000..e89f637
> --- /dev/null
> +++ b/arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi
> @@ -0,0 +1,42 @@
> +/*
> + * PQ3 TDM device tree stub [ controller @ offset 0x16000 ]
> + *
> + * Copyright 2012 Freescale Semiconductor Inc.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions are met:
> + * * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * * Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in the
> + * documentation and/or other materials provided with the distribution.
> + * * Neither the name of Freescale Semiconductor nor the
> + * names of its contributors may be used to endorse or promote products
> + * derived from this software without specific prior written permission.
> + *
> + *
> + * ALTERNATIVELY, this software may be distributed under the terms of the
> + * GNU General Public License ("GPL") as published by the Free Software
> + * Foundation, either version 2 of that License or (at your option) any
> + * later version.
> + *
> + * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS'' AND ANY
> + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
> + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
> + * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY
> + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
> + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
> + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
> + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +tdm@16000 {
> + compatible = "fsl,tdm1.0";
> + reg = <0x16000 0x200 0x2c000 0x2000>;
> + clock-frequency = <0>;
> + tdm_tx_clk = <2048000>;
> + interrupts = <62 8 0 0>;
> + fsl,max-time-slots = <128>;
> +};
> --
> 1.7.6.GIT
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* RE: [PATCH 1/4] Device tree entry for Freescale TDM controller
2013-03-07 13:34 ` [PATCH 1/4] Device tree entry for Freescale TDM controller Russell King - ARM Linux
@ 2013-03-13 5:17 ` Singh Sandeep-B37400
0 siblings, 0 replies; 14+ messages in thread
From: Singh Sandeep-B37400 @ 2013-03-13 5:17 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Aggrwal Poonam-B10812, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
> -----Original Message-----
> From: Russell King - ARM Linux [mailto:linux@arm.linux.org.uk]
> Sent: Thursday, March 07, 2013 7:04 PM
> To: Singh Sandeep-B37400
> Cc: linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org;
> Aggrwal Poonam-B10812
> Subject: Re: [PATCH 1/4] Device tree entry for Freescale TDM controller
>=20
> I know I'm probably missing something... but... why are these patches
> copied to the ARM list? They appear to be PowerPC patches.
There was a request from few ARM Linux developers that they were interested
in developing TDM subsystem for ARM and would like to see TDM patches in
ARM mailing list. Just trying to oblige
>=20
> On Thu, Mar 07, 2013 at 04:57:45PM +0530, Sandeep Singh wrote:
> > Added dtsi file for Freescale TDM controller.
> > This controller is available on many Freescale SOCs like MPC8315,
> > P1020, P1010,
> > P1022 and P1024
> > Signed-off-by: Sandeep Singh <Sandeep@freescale.com>
> > Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
> > ---
> > arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi | 42
> +++++++++++++++++++++++++++
> > 1 files changed, 42 insertions(+), 0 deletions(-) create mode 100644
> > arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi
> >
> > diff --git a/arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi
> > b/arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi
> > new file mode 100644
> > index 0000000..e89f637
> > --- /dev/null
> > +++ b/arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi
> > @@ -0,0 +1,42 @@
> > +/*
> > + * PQ3 TDM device tree stub [ controller @ offset 0x16000 ]
> > + *
> > + * Copyright 2012 Freescale Semiconductor Inc.
> > + *
> > + * Redistribution and use in source and binary forms, with or without
> > + * modification, are permitted provided that the following conditions
> are met:
> > + * * Redistributions of source code must retain the above
> copyright
> > + * notice, this list of conditions and the following disclaimer.
> > + * * Redistributions in binary form must reproduce the above
> copyright
> > + * notice, this list of conditions and the following disclaimer
> in the
> > + * documentation and/or other materials provided with the
> distribution.
> > + * * Neither the name of Freescale Semiconductor nor the
> > + * names of its contributors may be used to endorse or promote
> products
> > + * derived from this software without specific prior written
> permission.
> > + *
> > + *
> > + * ALTERNATIVELY, this software may be distributed under the terms of
> > +the
> > + * GNU General Public License ("GPL") as published by the Free
> > +Software
> > + * Foundation, either version 2 of that License or (at your option)
> > +any
> > + * later version.
> > + *
> > + * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS'' AND
> > +ANY
> > + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> > +IMPLIED
> > + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> > +ARE
> > + * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE
> > +FOR ANY
> > + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> > +DAMAGES
> > + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
> > +SERVICES;
> > + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
> > +CAUSED AND
> > + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
> > +OR TORT
> > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
> > +USE OF THIS
> > + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> > + */
> > +
> > +tdm@16000 {
> > + compatible =3D "fsl,tdm1.0";
> > + reg =3D <0x16000 0x200 0x2c000 0x2000>;
> > + clock-frequency =3D <0>;
> > + tdm_tx_clk =3D <2048000>;
> > + interrupts =3D <62 8 0 0>;
> > + fsl,max-time-slots =3D <128>;
> > +};
> > --
> > 1.7.6.GIT
> >
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH 1/4] Device tree entry for Freescale TDM controller
2013-03-07 11:27 [PATCH 1/4] Device tree entry for Freescale TDM controller Sandeep Singh
` (3 preceding siblings ...)
2013-03-07 13:34 ` [PATCH 1/4] Device tree entry for Freescale TDM controller Russell King - ARM Linux
@ 2013-03-20 10:51 ` Singh Sandeep-B37400
2013-03-29 9:34 ` Singh Sandeep-B37400
2013-06-28 22:15 ` [1/4] " Scott Wood
5 siblings, 1 reply; 14+ messages in thread
From: Singh Sandeep-B37400 @ 2013-03-20 10:51 UTC (permalink / raw)
To: linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Cc: Aggrwal Poonam-B10812
Any comments on this patch set??
Regards,
Sandeep
> -----Original Message-----
> From: Singh Sandeep-B37400
> Sent: Thursday, March 07, 2013 4:58 PM
> To: linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org
> Cc: Singh Sandeep-B37400; Aggrwal Poonam-B10812
> Subject: [PATCH 1/4] Device tree entry for Freescale TDM controller
^ permalink raw reply [flat|nested] 14+ messages in thread* RE: [PATCH 1/4] Device tree entry for Freescale TDM controller
2013-03-20 10:51 ` Singh Sandeep-B37400
@ 2013-03-29 9:34 ` Singh Sandeep-B37400
0 siblings, 0 replies; 14+ messages in thread
From: Singh Sandeep-B37400 @ 2013-03-29 9:34 UTC (permalink / raw)
To: linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Cc: Aggrwal Poonam-B10812
A gentle reminder.
Any comments are appreciated.
Regards,
Sandeep
> -----Original Message-----
> From: Linuxppc-dev [mailto:linuxppc-dev-
> bounces+sandeep=3Dfreescale.com@lists.ozlabs.org] On Behalf Of Singh
> Sandeep-B37400
> Sent: Wednesday, March 20, 2013 4:22 PM
> To: linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org
> Cc: Aggrwal Poonam-B10812
> Subject: RE: [PATCH 1/4] Device tree entry for Freescale TDM controller
>=20
> Any comments on this patch set??
>=20
> Regards,
> Sandeep
>=20
>=20
> > -----Original Message-----
> > From: Singh Sandeep-B37400
> > Sent: Thursday, March 07, 2013 4:58 PM
> > To: linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org
> > Cc: Singh Sandeep-B37400; Aggrwal Poonam-B10812
> > Subject: [PATCH 1/4] Device tree entry for Freescale TDM controller
>=20
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [1/4] Device tree entry for Freescale TDM controller
2013-03-07 11:27 [PATCH 1/4] Device tree entry for Freescale TDM controller Sandeep Singh
` (4 preceding siblings ...)
2013-03-20 10:51 ` Singh Sandeep-B37400
@ 2013-06-28 22:15 ` Scott Wood
2013-07-01 4:59 ` Singh Sandeep-B37400
5 siblings, 1 reply; 14+ messages in thread
From: Scott Wood @ 2013-06-28 22:15 UTC (permalink / raw)
To: Sandeep Singh; +Cc: Poonam Aggrwal, linuxppc-dev, linux-arm-kernel
On Thu, Mar 07, 2013 at 04:57:45PM +0530, Sandeep Singh wrote:
> +tdm@16000 {
> + compatible = "fsl,tdm1.0";
> + reg = <0x16000 0x200 0x2c000 0x2000>;
> + clock-frequency = <0>;
> + tdm_tx_clk = <2048000>;
> + interrupts = <62 8 0 0>;
> + fsl,max-time-slots = <128>;
> +};
tdm_tx_clk isn't in the binding (and should be named fsl,tdm-tx-clk if it
is meant to be here at all).
-Scott
^ permalink raw reply [flat|nested] 14+ messages in thread* RE: [1/4] Device tree entry for Freescale TDM controller
2013-06-28 22:15 ` [1/4] " Scott Wood
@ 2013-07-01 4:59 ` Singh Sandeep-B37400
0 siblings, 0 replies; 14+ messages in thread
From: Singh Sandeep-B37400 @ 2013-07-01 4:59 UTC (permalink / raw)
To: Wood Scott-B07421
Cc: Aggrwal Poonam-B10812, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: 29 June 2013 03:46
> To: Singh Sandeep-B37400
> Cc: linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org;
> Aggrwal Poonam-B10812
> Subject: Re: [1/4] Device tree entry for Freescale TDM controller
>=20
> On Thu, Mar 07, 2013 at 04:57:45PM +0530, Sandeep Singh wrote:
> > +tdm@16000 {
> > + compatible =3D "fsl,tdm1.0";
> > + reg =3D <0x16000 0x200 0x2c000 0x2000>;
> > + clock-frequency =3D <0>;
> > + tdm_tx_clk =3D <2048000>;
> > + interrupts =3D <62 8 0 0>;
> > + fsl,max-time-slots =3D <128>;
> > +};
>=20
> tdm_tx_clk isn't in the binding (and should be named fsl,tdm-tx-clk if it
> is meant to be here at all).
I will add it in the binding.
Thanks,
Sandeep
>=20
> -Scott
^ permalink raw reply [flat|nested] 14+ messages in thread