From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Anton Blanchard <anton@samba.org>
Cc: mikey@neuling.org, paulus@samba.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: handle unaligned ldbrx/stdbrx
Date: Wed, 31 Jul 2013 18:19:23 +1000 [thread overview]
Message-ID: <20130731181923.270ccd5b2b9438cf8f8c6887@canb.auug.org.au> (raw)
In-Reply-To: <20130731150521.74eb6639@kryten>
[-- Attachment #1: Type: text/plain, Size: 747 bytes --]
Hi Anton,
On Wed, 31 Jul 2013 15:05:21 +1000 Anton Blanchard <anton@samba.org> wrote:
>
> +++ b/arch/powerpc/kernel/align.c
> @@ -764,6 +764,16 @@ int fix_alignment(struct pt_regs *regs)
> nb = aligninfo[instr].len;
> flags = aligninfo[instr].flags;
>
> + /* ldbrx/stdbrx overlap lfs/stfs in the DSISR unfortunately */
> + if (IS_XFORM(instruction) && ((instruction >> 1) & 0x3ff) == 532) {
We have get_xop() in asm/disassemble.h (which is unfortunately not
included by this file) ...
> + nb = 8;
> + flags = LD+SW;
> + } else if (IS_XFORM(instruction) &&
> + ((instruction >> 1) & 0x3ff) == 660) {
ditto
/me points at a bike shed :-)
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-07-31 8:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 5:05 [PATCH] powerpc: handle unaligned ldbrx/stdbrx Anton Blanchard
2013-07-31 8:19 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731181923.270ccd5b2b9438cf8f8c6887@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=anton@samba.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox