From: Michael Ellerman <michael@ellerman.id.au>
To: Fionnuala Gunter <fin@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] drivers/crypto/nx: saves chaining value from co-processor
Date: Mon, 5 Aug 2013 12:21:21 +1000 [thread overview]
Message-ID: <20130805022120.GA5281@concordia> (raw)
In-Reply-To: <1375481816.32477.22.camel@what-is-leg>
On Fri, Aug 02, 2013 at 05:16:56PM -0500, Fionnuala Gunter wrote:
> On Sat, 2013-08-03 at 07:59 +1000, Benjamin Herrenschmidt wrote:
> > On Fri, 2013-08-02 at 16:55 -0500, Fionnuala Gunter wrote:
> > > Sorry, I thought linuxppc-dev was the right tree since the patch is
> > > for
> > > a ppc driver and you've carried previous nx driver submissions
> > > upstream.
> > >
> > > I want to submit to the proper place, so what is your preference?
> >
> > Well, that's the right place if you want me to merge it, which seems to
> > be what Marcelo is also expecting...
>
> Please merge this patch, it fixes a hot bug.
You don't actually mention that anywhere in the changelog.
The description implies that it's probably a bug, but doesn't describe
the symptoms in any way - does it make it completely non-functional or
just break in certain corner cases.
And you make no mention of when this bug appeared, has it always been
there, or was it introduced by a particular commit? That's important
because it helps determine whether the patch should go into any of the
stable trees.
cheers
prev parent reply other threads:[~2013-08-05 2:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 20:58 [PATCH] drivers/crypto/nx: saves chaining value from co-processor Fionnuala Gunter
2013-08-02 21:09 ` Benjamin Herrenschmidt
2013-08-02 21:55 ` Fionnuala Gunter
2013-08-02 21:59 ` Benjamin Herrenschmidt
2013-08-02 22:16 ` Fionnuala Gunter
2013-08-05 2:21 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130805022120.GA5281@concordia \
--to=michael@ellerman.id.au \
--cc=fin@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).