From: Paul Mackerras <paulus@samba.org>
To: Bhushan Bharat-R65777 <R65777@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"agraf@suse.de" <agraf@suse.de>,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s
Date: Wed, 7 Aug 2013 10:24:08 +1000 [thread overview]
Message-ID: <20130807002408.GE19254@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <6A3DF150A5B70D4F9B66A25E3F7C888D070FBE3B@039-SN2MPN1-012.039d.mgd.msft.net>
On Tue, Aug 06, 2013 at 07:02:48AM +0000, Bhushan Bharat-R65777 wrote:
>
> I am trying to me the Linux pte search and update generic so that this can be used for powerpc as well.
>
> I am not sure which of the below two should be ok, please help
Given that the BookE code uses gfn_to_pfn_memslot() to get the host
pfn, and then kvm_set_pfn_dirty(pfn) on pages that you're going to let
the guest write to, I don't think you need to set the dirty and/or
accessed bits in the Linux PTE explicitly. If you care about the
WIMGE bits you can do find_linux_pte_or_hugepte() and just look at the
PTE, but you really should be using mmu_notifier_retry() to guard
against concurrent changes to the Linux PTE. See the HV KVM code or
patch 21 of my recent series to see how it's used. You probably
should be calling kvm_set_pfn_accessed() as well.
Paul.
next prev parent reply other threads:[~2013-08-07 0:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 11:12 [PATCH 0/6 v2] kvm: powerpc: use cache attributes from linux pte Bharat Bhushan
2013-08-01 11:12 ` [PATCH 1/6 v2] powerpc: book3e: _PAGE_LENDIAN must be _PAGE_ENDIAN Bharat Bhushan
2013-08-01 11:12 ` [PATCH 2/6 v2] kvm: powerpc: allow guest control "E" attribute in mas2 Bharat Bhushan
2013-08-01 11:12 ` [PATCH 3/6 v2] kvm: powerpc: allow guest control "G" " Bharat Bhushan
2013-08-02 6:39 ` "“tiejun.chen”"
2013-08-01 11:12 ` [PATCH 4/6 v2] powerpc: move linux pte/hugepte search to more generic file Bharat Bhushan
2013-08-01 11:12 ` [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s Bharat Bhushan
2013-08-02 6:37 ` "“tiejun.chen”"
2013-08-02 22:58 ` Scott Wood
2013-08-02 23:16 ` Benjamin Herrenschmidt
2013-08-03 2:58 ` Bhushan Bharat-R65777
2013-08-03 4:24 ` Benjamin Herrenschmidt
2013-08-05 14:27 ` Bhushan Bharat-R65777
2013-08-05 19:19 ` Scott Wood
2013-08-06 1:12 ` Bhushan Bharat-R65777
2013-08-06 7:02 ` Bhushan Bharat-R65777
2013-08-07 0:24 ` Paul Mackerras [this message]
2013-08-07 1:11 ` Scott Wood
2013-08-07 1:47 ` Paul Mackerras
2013-08-06 14:46 ` Bhushan Bharat-R65777
2013-08-01 11:12 ` [PATCH 6/6 v2] kvm: powerpc: use caching attributes as per linux pte Bharat Bhushan
2013-08-02 6:24 ` "“tiejun.chen”"
2013-08-02 23:34 ` Scott Wood
2013-08-03 3:11 ` Bhushan Bharat-R65777
2013-08-03 4:25 ` Benjamin Herrenschmidt
2013-08-05 16:28 ` Scott Wood
2013-08-05 16:30 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130807002408.GE19254@iris.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=B07421@freescale.com \
--cc=R65777@freescale.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).