From: Michael Ellerman <michael@ellerman.id.au>
To: Mike Qiu <qiudayu@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, shangw@linux.vnet.ibm.com
Subject: Re: [PATCH] powerpc/eeh: Fix undefined variable
Date: Wed, 7 Aug 2013 15:11:24 +1000 [thread overview]
Message-ID: <20130807051124.GA19998@concordia> (raw)
In-Reply-To: <1375842286-26521-1-git-send-email-qiudayu@linux.vnet.ibm.com>
On Tue, Aug 06, 2013 at 10:24:46PM -0400, Mike Qiu wrote:
> 'pe_no' hasn't been defined, it should be an typo error,
> it should be 'frozen_pe_no'.
>
> Also '__func__' should be added to IODA_EEH_DBG(),
>
> Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
> ---
> arch/powerpc/platforms/powernv/eeh-ioda.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/powernv/eeh-ioda.c b/arch/powerpc/platforms/powernv/eeh-ioda.c
> index 0cd1c4a..a49bee7 100644
> --- a/arch/powerpc/platforms/powernv/eeh-ioda.c
> +++ b/arch/powerpc/platforms/powernv/eeh-ioda.c
> @@ -843,7 +843,8 @@ static int ioda_eeh_next_error(struct eeh_pe **pe)
> * specific PHB.
> */
> IODA_EEH_DBG("%s: Error (%d, %d, %d) on PHB#%x\n",
> - err_type, severity, pe_no, hose->global_number);
> + __func__, err_type, severity,
> + frozen_pe_no, hose->global_number);
Why is it using a custom macro? If you use pr_devel() or similar you
avoid these bugs, because the argument list is always expanded.
cheers
next prev parent reply other threads:[~2013-08-07 5:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 2:24 [PATCH] powerpc/eeh: Fix undefined variable Mike Qiu
2013-08-07 2:34 ` Gavin Shan
2013-08-07 5:11 ` Michael Ellerman [this message]
2013-08-07 5:25 ` Gavin Shan
2013-08-07 5:37 ` Mike Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130807051124.GA19998@concordia \
--to=michael@ellerman.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qiudayu@linux.vnet.ibm.com \
--cc=shangw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).