linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linuxppc-dev@lists.ozlabs.org, Wolfram Sang <w.sang@pengutronix.de>
Subject: Re: [PATCH] powerpc: 52xx: provide a default in mpc52xx_irqhost_map()
Date: Tue, 13 Aug 2013 00:16:54 +0200	[thread overview]
Message-ID: <20130813001654.16d67af6@crub> (raw)
In-Reply-To: <1376317073-14302-1-git-send-email-bigeasy@linutronix.de>

On Mon, 12 Aug 2013 16:17:53 +0200
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:

> My gcc-4.3.5 fails to compile due to:
>=20
> |cc1: warnings being treated as errors
> |arch/powerpc/platforms/52xx/mpc52xx_pic.c: In function =E2=80=98mpc52xx_=
irqhost_map=E2=80=99:
> |arch/powerpc/platforms/52xx/mpc52xx_pic.c:343: error: =E2=80=98irqchip=
=E2=80=99 may be used uninitialized in this function
>=20
> since commit e34298c ("powerpc: 52xx: nop out unsupported critical
> IRQs"). This warning is complete crap since only values 0=E2=80=A63 are p=
ossible
> which are checked but gcc fails to understand that. I wouldn't care much
> but since this is compiled with -Werror I made this patch.
> While add it, I replaced the warning from l2irq to l1irq since this is
> the number that is evaluated.
>=20
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>  arch/powerpc/platforms/52xx/mpc52xx_pic.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks!

Anatolij

      reply	other threads:[~2013-08-12 22:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12 14:17 [PATCH] powerpc: 52xx: provide a default in mpc52xx_irqhost_map() Sebastian Andrzej Siewior
2013-08-12 22:16 ` Anatolij Gustschin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130813001654.16d67af6@crub \
    --to=agust@denx.de \
    --cc=bigeasy@linutronix.de \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).