From: Nicolin Chen <b42378@freescale.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
lars@metafoo.de, timur@tabi.org, rob.herring@calxeda.com,
broonie@kernel.org, p.zabel@pengutronix.de,
Shawn Guo <shawn.guo@linaro.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver
Date: Wed, 14 Aug 2013 10:09:12 +0800 [thread overview]
Message-ID: <20130814020911.GA31651@MrMyself> (raw)
In-Reply-To: <CAOMZO5A7noEb98yuCPY6o2mf-FikFcMYiDLpg3huPKHMO7Fwdw@mail.gmail.com>
Hi Fabio,
Thank you for the comments.
On Tue, Aug 13, 2013 at 02:58:26PM -0300, Fabio Estevam wrote:
> On Mon, Aug 12, 2013 at 9:01 AM, Nicolin Chen <b42378@freescale.com> wrote:
> > +Required properties:
> > +
> > + - compatible : Compatible list, contains "fsl,<chip>-spdif". Using general
>
> Can't we just use "fsl,fsl-spdif" instead?
>
> > + "fsl,fsl-spdif" will get the default SoC type -- imx6q-spdif.
> > +
>
> I think this is not the usual approach we do with dt.
>
> > +static const struct of_device_id fsl_spdif_dt_ids[] = {
> > + { .compatible = "fsl,fsl-spdif", },
>
> Isn't only the first entry enough here?
I just saw Mark's words as well. So I don't need to change this part right?
But I'd like to add imx35 on it.
> This MODULE_ALIAS name does not match the name you provided earlier:
>
> .name = "fsl-spdif-dai"
>
I'll fix it in v5.
Best regards,
Nicolin Chen
next prev parent reply other threads:[~2013-08-14 2:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 12:01 [PATCH v4 0/2] Add freescale S/PDIF CPU DAI and machine drivers Nicolin Chen
2013-08-12 12:01 ` [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver Nicolin Chen
2013-08-13 17:58 ` [alsa-devel] " Fabio Estevam
2013-08-13 19:01 ` Fabio Estevam
2013-08-13 19:02 ` Mark Brown
2013-08-14 2:09 ` Nicolin Chen [this message]
2013-08-14 3:27 ` Shawn Guo
2013-08-14 5:30 ` Nicolin Chen
2013-08-14 6:39 ` Shawn Guo
2013-08-14 6:34 ` Nicolin Chen
2013-08-14 8:14 ` Shawn Guo
2013-08-14 15:47 ` Stephen Warren
2013-08-15 2:18 ` Nicolin Chen
2013-08-15 9:24 ` Shawn Guo
2013-08-16 22:49 ` Stephen Warren
2013-08-12 12:01 ` [PATCH v4 2/2] ASoC: fsl: Add S/PDIF machine driver Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814020911.GA31651@MrMyself \
--to=b42378@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=lars@metafoo.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=rob.herring@calxeda.com \
--cc=shawn.guo@linaro.org \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).